Aside from the fact that changing accelerator keys would (as it always does) cause annoyance for users (but I assume you have considered that and decided that these improvements justify it), I'm not sure I understand the reasoning behind moving of the 'check for updates' item out of the help menu. Looking at other programs I have installed the only one in which ability to check for updates is not in the help menu is MS Office, though that is likely because it auto-updates in the background. In all other cases (Firefox, JAWS, Acrobat Reader, Notepad++, VS Code...) this option is in the help menu, so that seems to be standard placement. It is also worth pointing out, though this may may affect only more advanced users, that for try builds, source copies, etc. this option is hidden, so if i weren't following this thread, updated to the version with this change,pressed NVDA + N -> H -> C (as I've been doing for years to check for updates), and notice that the option is not there, it is likely I would try to debug why my update check stopped working, and don't think to look throughout the entire menu. If you want to group these options together it appears more logical to move "install pending update' to the help menu, rather than the other way around. Also has it been considered to make 'documentation' a sub menu of the help menu, instead of its own, independent menu?

We'd like more feedback on these changes before making a decision and merging

Also has it been considered to make 'documentation' a sub menu of the help menu, instead of its own, independent menu?

Depth is more annoying to navigate, and only 2 of the docs in the submenu are related to "help" (user guide, key commands).

I'm not a big fan of changing the entry for checking for updates and documentation, besides breaking the accelerator habit would be confusing, there are many external tutorials or add-on documentation that may also mention the path to these documents.

Many applications include the Check for/Install updates option, at the top of their About dialog, with the version number. That doesn't mean we should, it is just one of the common placements. Others, as @lukaszgo1 said, put it in the Help menu if they have one. Rarely have I noticed it in the main Window, which for us would be on the main menu. Personally I prefer that it remain where it has traditionally been.

The main reason to move it is for discoverability and to keep it with the "install pending update" item. Moving the other item to the help menu would decrease the discoverability of pending updates. We can stick with convention but checking for an update doesn't really fit under "Help" logically.
I think being able to check for update from the about dialog as well would be a nice to have.

The main reason to move it is for discoverability and to keep it with the "install pending update" item. Moving the other item to the help menu would decrease the discoverability of pending updates.

It may be more discoverable visually, but for blind users this does not really matter - they need to move through the entire menu to find it regardless in which one these options are placed. I would say the main way people install pending updates is either from the pending update reminder on startup, or from the exit dialog, though I don't have any scientific evidence to back this up.

Considering it is safer to stick with convention for the check for update, that change has been reverted

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/gow7b98qc0braa1p/artifacts/output/nvda_snapshot_pr15688-29788,d4979a25.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 24.6,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 7.7,
  FINISH_END 0.1

See test results for failed build of commit d4979a25c7

I think this PR was merged too early. He doesn’t seem to be hearing enough from the community. In my opinion, "documentation" also falls under the category of help.
Sorry, I don't see any obvious benefit to having Documents as a separate menu.

I also comment a bit late.
I have no very strong impression about this change and will not fight in any direction to have it modified, i.e. I will not open a new issue or PR to optimize this.

Anyway here is my personal impression:
The documentation menu does not bring anything interesting. Specifically, in many applications, the help doc (user guide) can be found in the Help menu. I feel that separating Help and Documentation may lead to confusion, i.e. "I do not remember if User Guide is in Help or in Documentation".
Maybe the scope for splitting the help menu was to avoid a menu with too much items? In this case, a submenu "Useful links" under the Help menu can group all the links on NV Access website.
I agree that the User Guide should not be put in a 2nd sublevel menu; but for links on NV Access website, I think that it may be acceptable.

At last, I note that adding more items pointing on NV Access website may not be so interesting for non-English speaking users of NVDA; this issue was already present with the link on the main page of NV Access website, but adding these new links makes it more noticeable.

It looks like the "check for updates" reversion wasn't successful, and its placement in the root menu is confusing, misleading, and breaks years of muscle memory.

I like the proposal by @CyrilleB79 to restore the "documentation" items back to the help menu, and add a "useful links" (or similar) submenu.

Lets move the discussion to #15740. Comments on closed pull requests are easily missed.

Actually the discussion takes place in #15749.