Return “Check for updates” to help menu#15741
Merged
Merged
Conversation
The key changed from C to U. Close nvaccess#15740
Contributor
|
I think this option was supposed to be moved back to the help menu (which I'm strongly in favour of). |
seanbudd
reviewed
Nov 6, 2023
| if updateCheck: | ||
| # Translators: The label of a menu item to manually check for an updated version of NVDA. | ||
| item = self.menu.Append(wx.ID_ANY, _("&Check for update...")) | ||
| item = self.menu.Append(wx.ID_ANY, _("Check for &update...")) |
Member
There was a problem hiding this comment.
Can you please update the PR description and title to reflect the intended change, to keep "check for update" in the help menu
Suggested change
| item = self.menu.Append(wx.ID_ANY, _("Check for &update...")) | |
| item = menu_help.Append(wx.ID_ANY, _("&Check for update...")) |
See test results for failed build of commit c3eb16292f |
Member
|
Thanks @OzancanKaratas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Close #15740
Summary of the issue:
#15688 moved “Check for update” to the NVDA main menu.
Description of user facing changes
The user can again use the “Check for update” option in the Help menu.
Description of development approach
None
Testing strategy:
As before, open the Help menu and check for NVDA updates.
Known issues with pull request:
None
Code Review Checklist: