Skip to content

Revert creation of Doc Menu, move back to Help menu#15762

Merged
seanbudd merged 2 commits into
masterfrom
revertDocMenu
Nov 10, 2023
Merged

Revert creation of Doc Menu, move back to Help menu#15762
seanbudd merged 2 commits into
masterfrom
revertDocMenu

Conversation

@seanbudd

@seanbudd seanbudd commented Nov 9, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15749
Partially reverts #15688

Summary of the issue:

There has been significant negative feedback to the creation of the documentation menu.
Instead items should be return to the help menu.
Given that there is now 11 items in the Help menu, more separators should be added.

Description of user facing changes

The new help menu structure is:

  • User Guide
  • Key commands
  • Changes
  • [separator]
  • NV Access website
  • NV Access Get Help page
  • NV Access Shop page
  • [separator]
  • License
  • Contributors
  • [separator]
  • Welcome dialog
  • Check for update
  • About dialog

Description of development approach

Move items back, remove internal variable menu_help which duplicated self.helpMenu

Testing strategy:

Tested viewing and using the help menu

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner November 9, 2023 01:53
@seanbudd seanbudd merged commit 56bad26 into master Nov 10, 2023
@seanbudd seanbudd deleted the revertDocMenu branch November 10, 2023 03:36
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to revert #15688 and reorganize the structure of the help menu.

3 participants