[EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration, Deployer Coverage, UX Baseline. by KPrasch · Pull Request #1124 · nucypher/nucypher

KPrasch · 2019-07-16T23:49:16Z

Replaces PR #1107

The goal of this PR is to follow up the core Staker-Worker separation changes in #1029 by introducing the StakeHolder python and (nucypher stake) command-line interfaces and re-integrates Ursula entry points with consideration to the Worker role.

stakeholder CLI commands

nucypher stake new-stakeholder --provider-uri file:///tmp/geth.ipc --poa
nucypher stake init
nucypher stake list
nucypher stake accounts
nucypher stake divide
nucypher stake set-worker

Ramp

codecov · 2019-07-18T19:24:13Z

Codecov Report

Merging #1124 into master will decrease coverage by 1.03%.
The diff coverage is 78.97%.

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   83.12%   82.08%   -1.04%     
==========================================
  Files          70       72       +2     
  Lines        9252     9743     +491     
==========================================
+ Hits         7691     7998     +307     
- Misses       1561     1745     +184

Impacted Files	Coverage Δ
nucypher/config/keyring.py	`87.53% <ø> (-0.96%)`	⬇️
nucypher/characters/chaotic.py	`70.24% <ø> (+0.13%)`	⬆️
nucypher/characters/lawful.py	`90.14% <100%> (+0.05%)`	⬆️
nucypher/characters/control/interfaces.py	`96.26% <100%> (ø)`	⬆️
nucypher/cli/characters/enrico.py	`70.27% <100%> (+1.03%)`	⬆️
nucypher/blockchain/eth/registry.py	`74.13% <100%> (-3.88%)`	⬇️
nucypher/blockchain/eth/policies.py	`77.61% <100%> (+0.74%)`	⬆️
nucypher/cli/main.py	`100% <100%> (+11.47%)`	⬆️
nucypher/config/characters.py	`98.33% <100%> (-0.78%)`	⬇️
nucypher/blockchain/eth/constants.py	`100% <100%> (ø)`
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a560845...0df7d97. Read the comment docs.

…, Geth tranction formatting and signging.

…e same address multiple times.

…funding account recipt fix; Touch Ups.

… unneeded feature flags. Relocate deployment console painting to painting.py.

CLI Cleanup

CLI cleanup (vol. 2): Making CLI work with local non-dev private chain

…dates TODO: Possibility of doing per transaction progress

…e steps can take a long time. It is worth noting that only progress is updated for individual steps - the printing of the receipt confirmation to the console is not done until all receipts (from the inidividual step) are received by the deployer. Added unit tests for progress updates.

…ployment_transactions"

…r passed in CLI.

nucypher/cli/characters/alice.py

UX: Add the ability to provide progress during NuCypher contract deployments

KPrasch added Ursula 👩‍🚀 Effects the "Ursula" development area API CLI This effects the nucypher CLI Configuration Node configuration labels Jul 17, 2019

KPrasch changed the title ~~[WIP] [EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration~~ [WIP] [EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration, Deployer Coverage, UX Baseline. Jul 22, 2019

KPrasch mentioned this pull request Jul 23, 2019

Geth managed hardware wallets #1117

Closed

5 tasks

KPrasch requested review from cygnusv, derekpierre, fjarri, jMyles, michwill, tuxxy and vepkenez July 25, 2019 19:23

KPrasch added 16 commits July 25, 2019 15:18

Introduce StakeHolder

8c11576

Second daraft of StakeHolder including JSON config.

d7b03de

Detailing StakeHolder actions

3953da7

Updates stakeholder to used unified BlockchainInterface API

7006891

Stakeholder power-tracking, and quasi-character blockchain persistence

7d3c80a

Include worker address sync in Stake; Blockchain to/from dict payload…

3bc659b

…, Geth tranction formatting and signging.

Ensure access to geth accounts pre-character-init

d55a63f

Optional allowance detection for TokenAgency to ease stake init on th…

ce9002f

…e same address multiple times.

Improve Stakeholder API tests.

e1cb849

xAdvance Stakeholder rewards integration testing.

13ed350

BYOK for stakeholder and worker - Passing collect inflation reward test.

f7d7806

Respond to RFCs in PR #1064 - Staker to/from blockchain, @michwill's …

362aff4

…funding account recipt fix; Touch Ups.

Adds integration test for creating new geth accounts over RPC clients.

7b16196

Extracts staking CLI to 'nucypher stake' entry point

4803831

Update ursula CLI tests to use new stake entry points

17aa2ed

Second pass - Skeleton layout for staking CLI

0dea0f0

KPrasch and others added 21 commits July 27, 2019 19:01

Improve code conventions and comments for nucypher-deploy CLI; remove…

cdce42d

… unneeded feature flags. Relocate deployment console painting to painting.py.

Merge pull request #1146 from KPrasch/output-refactoring

bd12cc9

CLI Cleanup

Pass --sync flag value to Stakeholder initialization

9ce48d6

Workaround for #1165 (segfault)

a4f2474

Disable automatic download of registry when one is provided. Fixes #1166

fe28261

Fix wrong sender in nucypher-deploy transfer. Improve UX too.

9ac51f1

Slightly more informative and comfortable deployment of contracts

f9336f2

Print receipt after successful nucypher stake set-worker

11f4169

Adapt painting of nucypher stake init/divide to stakeholder, not ursulas

6bb1e2e

Add test_transfer_tokens to nucypher-deploy tests. Remove unused stuff.

ca732b5

Improve some CLI messages

460dd6a

Make ursula CLI ask for worker account password

eed4c09

No need to unlock in substantiate_stamp when TransactingPower is active

f969b62

Remove second stamp substantiation. Fix #1091

8dcf5a7

Adapt Ursula CLI tests to being asked for worker account password

1bd2aae

Merge pull request #1167 from cygnusv/moomin

648f120

CLI cleanup (vol. 2): Making CLI work with local non-dev private chain

Add the ability for per-DeployerClass contract deployment progress up…

504bd78

…dates TODO: Possibility of doing per transaction progress

Remove dev testing code

00d4155

Update deployer class property to be more descriptive - "number_of_de…

3424ff6

…ployment_transactions"

Set "interactive" deployment flag to be set based on 'force' paramete…

385f474

…r passed in CLI.

tuxxy approved these changes Jul 29, 2019

View reviewed changes

derekpierre reviewed Jul 29, 2019

View reviewed changes

nucypher/cli/characters/alice.py Show resolved Hide resolved

cygnusv added 2 commits July 30, 2019 11:30

Some click.progressbar hacks to make deploy even more shiny

6e292b7

Merge pull request #1170 from derekpierre/progressbar

0df7d97

UX: Add the ability to provide progress during NuCypher contract deployments

cygnusv approved these changes Jul 30, 2019

View reviewed changes

vepkenez approved these changes Jul 30, 2019

View reviewed changes

vepkenez merged commit b8792b7 into master Jul 30, 2019

cygnusv mentioned this pull request Jul 31, 2019

nucypher stake --help option #834

Closed

jMyles deleted the sekanjabin branch February 24, 2020 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration, Deployer Coverage, UX Baseline.#1124

[EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration, Deployer Coverage, UX Baseline.#1124
vepkenez merged 122 commits intomasterfrom
sekanjabin

KPrasch commented Jul 16, 2019 •

edited

Loading

Uh oh!

codecov bot commented Jul 18, 2019 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

KPrasch commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

stakeholder CLI commands

Ramp

Uh oh!

codecov bot commented Jul 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KPrasch commented Jul 16, 2019 •

edited

Loading

codecov bot commented Jul 18, 2019 •

edited

Loading