Merged
Conversation
d4058e3 to
26404cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
- Coverage 82.96% 79.44% -3.53%
==========================================
Files 70 70
Lines 9222 9252 +30
==========================================
- Hits 7651 7350 -301
- Misses 1571 1902 +331
Continue to review full report at Codecov.
|
0fa6cd0 to
1459a8a
Compare
549a64f to
60760bd
Compare
6 tasks
54353f1 to
ecc1f77
Compare
Member
|
Is this meant to be merged directly to master or to sekanjabin? |
Member
Author
tuxxy
reviewed
Jul 8, 2019
michwill
reviewed
Jul 9, 2019
…ugh consuming the TransactingPower.
…ments and touch ups to suit.
… function init signature.
…rs from Felix. Lazify solidity configuration for deployer interface connections.
a09d2ae to
0de6912
Compare
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 15, 2019
Apply suggestions from code review Co-Authored-By: David Núñez <david@nucypher.com>
0de6912 to
2e26f57
Compare
derekpierre
approved these changes
Jul 15, 2019
tuxxy
reviewed
Jul 15, 2019
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalizes
BlockchainPowerasTransactingPower, which can be "activated" through character consumption, and attached to aBlockchainInterfaceto give it the "power" to transact throughTransactingPower.sign_transaction. Provides a canonical method for transaction signing that can handle both hardware and software signing backends.Extracted from concept PR #1082
Fixes: #1024 #349
Supports hardware wallet transactions via geth 1.9.0; Accommodates Items in #1117