Skip to content

[EPIC] NuCypher Staking Device Utility #1052

Merged
cygnusv merged 21 commits intomasterfrom
mimosa
Jul 12, 2019
Merged

[EPIC] NuCypher Staking Device Utility #1052
cygnusv merged 21 commits intomasterfrom
mimosa

Conversation

@tuxxy
Copy link
Contributor

@tuxxy tuxxy commented Jun 5, 2019 •
edited by KPrasch
Loading

Description WIP

Based on #1029

@KPrasch KPrasch changed the title [EPIC] NuCypher Staking Utility [EPIC] NuCypher Staking Device Utility Jun 14, 2019
@codecov
Copy link

codecov bot commented Jun 15, 2019 •
edited
Loading

Codecov Report

Merging #1052 into master will decrease coverage by 18.98%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1052       +/-   ##
===========================================
- Coverage   81.25%   62.26%   -18.99%     
===========================================
  Files          69       70        +1     
  Lines        9201     9222       +21     
===========================================
- Hits         7476     5742     -1734     
- Misses       1725     3480     +1755
Impacted Files Coverage Δ
nucypher/cli/main.py 0% <ø> (-88.53%) ⬇️
nucypher/cli/hardware/backends.py 0% <0%> (ø)
nucypher/network/teachers.py 0% <0%> (-100%) ⬇️
nucypher/cli/types.py 0% <0%> (-81.49%) ⬇️
nucypher/cli/status.py 0% <0%> (-78.58%) ⬇️
nucypher/cli/deploy.py 0% <0%> (-78.27%) ⬇️
nucypher/cli/characters/alice.py 0% <0%> (-74.78%) ⬇️
nucypher/cli/actions.py 0% <0%> (-72.9%) ⬇️
nucypher/cli/characters/enrico.py 0% <0%> (-69.24%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4222912...d1980f9. Read the comment docs.

@tuxxy tuxxy force-pushed the mimosa branch 2 times, most recently from 2192082 to 37aa3e7 Compare June 21, 2019 19:29
This was referenced Jul 8, 2019
Merged
Closed
tuxxy and others added 18 commits July 11, 2019 15:39
@tuxxy
Add hardware module w/ TrustedDevice ABC for hardware staking
c8f26dc
@tuxxy
Add skeleton for a Trezor hardware backend
e2ff59f
@tuxxy
Implement signing and verifying methods for the Trezor backend
f92d0f9 
Fix abstractmethod verify_message signature
@tuxxy
Add passing tests for trezor backend and change imports to work with …
632aa8c 
…mocking
@tuxxy
Add abstractmethod for sign_eth_transaction on TrustedDevice
b7ed240
@tuxxy
Add reset and configure abstractmethods to TrustedDevice
5db818e
@tuxxy
Add __handle_device_call decorator for handling device API side effects
dc639b0
@tuxxy
Add test for call_handler_decorator and fix method declarations
438fe9b
@tuxxy
Add test for _reset and other unimplemented methods
e4182b2
@tuxxy
Move tests from wallet to device
44c2187
@tuxxy
Move mock_trezorlib et al to conftest in tests.cli
c8e3a63
@tuxxy
Add basic nucypher device cli entry point skeleton for testing
806cced
@tuxxy
Add tests for device CLI skeleton
f107980
@tuxxy
Move trezor specific imports to the Trezor.__init__
bdb6b00
@tuxxy
Add trezor[ethereum] dependency in dev-requirements
68a8dda
@KPrasch @tuxxy
Add trezor extra to setup.py
99744fd
@tuxxy
Hack usb1 import to work on CI machines without libusb
09f3370
@tuxxy
Remove deprecated code
4edd73e
@KPrasch KPrasch added API Enhancement New or improved features labels Jul 11, 2019
@KPrasch
Copy link
Member

KPrasch commented Jul 12, 2019

This PR tells an incredible story.

Good for merge. 🤠

@KPrasch KPrasch marked this pull request as ready for review July 12, 2019 00:24
michwill
michwill approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@michwill michwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fascinating. What purpose does this epic serve now: an ABC for Yubi?

cygnusv
cygnusv approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@cygnusv cygnusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuxxy Thanks for this hard work, man! It's sad seeing this great code come and go due to timing :'(

tests/cli/conftest.py
import json
import os
import shutil
import sys
Copy link
Member

@cygnusv cygnusv Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import sys

@cygnusv cygnusv merged commit 79a4334 into master Jul 12, 2019
@jMyles jMyles deleted the mimosa branch February 24, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPrasch KPrasch KPrasch approved these changes

@cygnusv cygnusv cygnusv approved these changes

@fjarri fjarri Awaiting requested review from fjarri

@jMyles jMyles Awaiting requested review from jMyles

+1 more reviewer

@michwill michwill michwill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement New or improved features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tuxxy @KPrasch @michwill @cygnusv