[WIP] [EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration#1107
Closed
[WIP] [EPIC] Sekanjabin - StakeHolder & Worker-Ursula Integration#1107
Conversation
cygnusv
reviewed
Jul 5, 2019
| for ursula in federated_ursulas: | ||
| deployer = ursula.get_deployer() | ||
| assert deployer.options['https_port'] == ursula.rest_interface.port | ||
| assert deployer.options['https_port'] == ursula.rest_information()[0].port |
Member
cygnusv
reviewed
Jul 5, 2019
| self._crypto_power.consume_power_up(transacting_power) | ||
|
|
||
| # Use blockchain power to substantiate stamp | ||
| self.substantiate_stamp(client_password=password) |
Member
There was a problem hiding this comment.
If the password was already provided when creating the TransactingPower, isn't here redundant? After all, stamp substantiation only makes sense when TransactingPower is active.
Merged
…ugh consuming the TransactingPower.
…ments and touch ups to suit.
… function init signature.
…rs from Felix. Lazify solidity configuration for deployer interface connections.
Apply suggestions from code review Co-Authored-By: David Núñez <david@nucypher.com>
TransactingPower
This was referenced Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to follow up the core Staker-Worker separation changes in #1029 by introducing the
StakeHolderpython and (nucypher stake) command-line interfaces and re-integrates Ursula entry points with consideration to theWorkerrole.stakeholder CLI commands
Ramp