UX: Add the ability to provide progress during NuCypher contract deployments#1170
Merged
cygnusv merged 6 commits intonucypher:sekanjabinfrom Jul 30, 2019
Merged
UX: Add the ability to provide progress during NuCypher contract deployments#1170cygnusv merged 6 commits intonucypher:sekanjabinfrom
cygnusv merged 6 commits intonucypher:sekanjabinfrom
Conversation
KPrasch
reviewed
Jul 29, 2019
KPrasch
reviewed
Jul 29, 2019
…dates TODO: Possibility of doing per transaction progress
…e steps can take a long time. It is worth noting that only progress is updated for individual steps - the printing of the receipt confirmation to the console is not done until all receipts (from the inidividual step) are received by the deployer. Added unit tests for progress updates.
…ployment_transactions"
Codecov Report
@@ Coverage Diff @@
## sekanjabin #1170 +/- ##
==============================================
- Coverage 83.41% 82.83% -0.59%
==============================================
Files 72 72
Lines 9700 9738 +38
==============================================
- Hits 8091 8066 -25
- Misses 1609 1672 +63
Continue to review full report at Codecov.
|
KPrasch
approved these changes
Jul 29, 2019
cygnusv
approved these changes
Jul 30, 2019
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying NuCypher contracts during installation can take some time, so adding a progress bar would improve UX.
Note: deploying to a local blockchain will be much faster.
Example output from my testing