Minor CLI bug fixes for nucypher stake and nucypher ursula#1163
Minor CLI bug fixes for nucypher stake and nucypher ursula#1163KPrasch merged 7 commits intonucypher:sekanjabinfrom
Conversation
| checksum_address=manual_staker, | ||
| blockchain=testerchain) | ||
|
|
||
| assert not staker.worker_address No newline at end of file |
There was a problem hiding this comment.
Do we have a test where the specified address to detach does not match an actual worker?
There was a problem hiding this comment.
Can you elaborate? I think I don't understand what you mean.
There was a problem hiding this comment.
A test to determine how the detach-worker code would handle an invalid staking address being passed to it eg. passing "0x6d4D33A138896a7D82E198fcDB7F050FBe8642EA" (<- random) for the staking address.
Codecov Report
@@ Coverage Diff @@
## sekanjabin #1163 +/- ##
==============================================
- Coverage 83.63% 83.58% -0.06%
==============================================
Files 72 72
Lines 9644 9655 +11
==============================================
+ Hits 8066 8070 +4
- Misses 1578 1585 +7
Continue to review full report at Codecov.
|
| date = datetime_at_period(period=confirmed_period) | ||
|
|
||
| emitter.echo(f'\nActivity confirmed for period #{confirmed_period} ' | ||
| f'(starting at {date}) !!', bold=True, color='blue') |
| staking_reward, | ||
|
|
||
| ) -> None: | ||
| """ |
nucypher ursula initsuggests to runnucypher ursula stakeat the end #1162: Bad suggestion innucypher ursula initnucypher ursula initasks for ETH worker address twice (expected: once) #1160: Better account hint innucypher ursula initnucypher stake --help#1158: Help text fornucypher stakenucypher stake <wrong-action>simply prints banner #1142: Fail onnucypher stake <bad-action>nucypher ursula confirm-activitynucypher stake detach-worker: Useful in case the staker wants to remove her current relationship with her worker (e.g., the worker has been compromised, the worker is in a corrupt setting, etc.)