Skip to content

CLI cleanup (vol. 2): Making CLI work with local non-dev private chain#1167

Merged
KPrasch merged 13 commits intonucypher:sekanjabinfrom
cygnusv:moomin
Jul 29, 2019
Merged

CLI cleanup (vol. 2): Making CLI work with local non-dev private chain#1167
KPrasch merged 13 commits intonucypher:sekanjabinfrom
cygnusv:moomin

Conversation

@cygnusv
Copy link
Member

@cygnusv cygnusv commented Jul 28, 2019 •
edited
Loading

Based on #1146.

Tested with a local private chain, but mocking "goerli" (chain ID 5) in order to pass as a public chain (i.e., not local).
In case you want to replicate, this is my genesis file. I ran the geth node with the following params: --networkid 5 --nodiscover --verbosity 5 --mine --minerthreads=1

Steps followed:

# Deploy contracts

nucypher-deploy contracts --poa --provider file:///Users/david/dev/mi-genesis/geth.ipc


# Stakeholder

rm /Users/david/Library/Application\ Support/nucypher/stakeholder.json

nucypher stake new-stakeholder --provider ipc:///Users/david/dev/mi-genesis/geth.ipc  --poa --registry-filepath /Users/david/Library/Application\ Support/nucypher/contract_registry.json

# Fund staker

nucypher stake accounts --no-sync

nucypher-deploy transfer --poa --provider file:///Users/david/dev/mi-genesis/geth.ipc --amount 50000000000000000000000 --recipient-address 0xd590d3DD9070bc1155282F68A4577e6C364A7828

nucypher stake accounts --no-sync

# Create stake

nucypher stake init --no-sync

nucypher stake set-worker --no-sync

@cygnusv cygnusv changed the base branch from master to sekanjabin July 28, 2019 00:09
@codecov
Copy link

codecov bot commented Jul 28, 2019 •
edited
Loading

Codecov Report

Merging #1167 into sekanjabin will decrease coverage by 0.42%.
The diff coverage is 75.5%.

Impacted file tree graph

@@              Coverage Diff               @@
##           sekanjabin    #1167      +/-   ##
==============================================
- Coverage        83.4%   82.97%   -0.43%     
==============================================
  Files              72       72              
  Lines            9655     9700      +45     
==============================================
- Hits             8053     8049       -4     
- Misses           1602     1651      +49
Impacted Files Coverage Δ
nucypher/config/characters.py 99.16% <ø> (ø) ⬆️
nucypher/blockchain/eth/clients.py 57.05% <0%> (-0.73%) ⬇️
nucypher/blockchain/eth/actors.py 84.23% <100%> (ø) ⬆️
nucypher/characters/lawful.py 89.43% <100%> (+1.29%) ⬆️
nucypher/crypto/powers.py 94.26% <100%> (-0.71%) ⬇️
nucypher/blockchain/eth/interfaces.py 80.44% <100%> (ø) ⬆️
nucypher/cli/characters/moe.py 64% <100%> (ø) ⬆️
nucypher/cli/characters/felix.py 70.65% <100%> (ø) ⬆️
nucypher/network/nodes.py 80.21% <100%> (-1.63%) ⬇️
nucypher/cli/characters/ursula.py 62.32% <100%> (+0.52%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c5ecb...cd379b0. Read the comment docs.

@cygnusv
Copy link
Member Author

cygnusv commented Jul 29, 2019

With my latest commits, I have confirmed activity with Ursula CLI.
Plus, this fixes #1091 too.

cygnusv added 13 commits July 29, 2019 11:27
@cygnusv @KPrasch
Pass --sync flag value to Stakeholder initialization
9ce48d6
@cygnusv @KPrasch
Workaround for nucypher#1165 (segfault)
a4f2474
@cygnusv @KPrasch
Disable automatic download of registry when one is provided. Fixes nu…
fe28261 
…cypher#1166
@cygnusv @KPrasch
Fix wrong sender in nucypher-deploy transfer. Improve UX too.
9ac51f1
@cygnusv @KPrasch
Slightly more informative and comfortable deployment of contracts
f9336f2
@cygnusv @KPrasch
Print receipt after successful nucypher stake set-worker
11f4169
@cygnusv @KPrasch
Adapt painting of nucypher stake init/divide to stakeholder, not ursulas
6bb1e2e
@cygnusv @KPrasch
Add test_transfer_tokens to nucypher-deploy tests. Remove unused stuff.
ca732b5
@cygnusv @KPrasch
Improve some CLI messages
460dd6a
@cygnusv @KPrasch
Make ursula CLI ask for worker account password
eed4c09
@cygnusv @KPrasch
No need to unlock in substantiate_stamp when TransactingPower is active
f969b62
@cygnusv @KPrasch
Remove second stamp substantiation. Fix nucypher#1091
8dcf5a7
@cygnusv @KPrasch
Adapt Ursula CLI tests to being asked for worker account password
1bd2aae
KPrasch
KPrasch approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@KPrasch KPrasch merged commit 648f120 into nucypher:sekanjabin Jul 29, 2019
@KPrasch KPrasch mentioned this pull request Jul 29, 2019
Merged
13 tasks
@derekpierre derekpierre mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPrasch KPrasch KPrasch approved these changes

@vzotova vzotova vzotova approved these changes

@fjarri fjarri Awaiting requested review from fjarri

@tuxxy tuxxy Awaiting requested review from tuxxy

@jMyles jMyles Awaiting requested review from jMyles

@vepkenez vepkenez Awaiting requested review from vepkenez

+1 more reviewer

@michwill michwill michwill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cygnusv @KPrasch @michwill @vzotova