On h.quit() terminal settings are same as when neuron.hoc was imported.#3259
Conversation
system("stty sane") errcode is 139.
|
✔️ dd7514a -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
- Coverage 67.08% 67.08% -0.01%
==========================================
Files 571 571
Lines 111116 111116
==========================================
- Hits 74540 74539 -1
- Misses 36576 36577 +1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
✔️ 1c58958 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ c8c5b7b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 8ed8314 -> Azure artifacts URL |
|
|
✔️ 6309927 -> Azure artifacts URL |
|
I think part of this was merged in #3243, but I guess the new |
The check is needed to prevent an irrelevant error message(s) when stdin is not a terminal. For example, at the moment with the current master |
JCGoran
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the issue when we don't use stdin as input, so it's good to go.
…d. (#3259) * Print tcgetatt/tcsetattr error messages only if STDIN is a tty.
…d. (#3259) * Print tcgetatt/tcsetattr error messages only if STDIN is a tty.
At starting point, jelic/8.2-py313 #3319 had only two CI failures. Almost the entirety of this PR is to get 8.2 to pass CI. In addition it supports Python3.13. Bug fixes adopted from the master are #3239 Launching nrniv -python with Python 3.13.0 does not allow use of gui. #3259 On h.quit() terminal settings are same as when neuron.hoc was imported. #3243 save stdin terminal settings on import hoc and restore on h.quit() #3276 Python 3.13.1 broke [s for s in sl] where sl is a SectionList. Manual partial cherry-pick. Other PR attempts at fixing CI failures that can be closed when this PR is merged, are #3329 #3325 #3319 #3317 Many of the CI fixes are backports from #3028 #3040 #3303 #3105 #3278 bldnrnmacpkgcmake.sh was updated. It isolates a change (avoid breaking CI) with -DNRN_MAC_PKG=ON --------- Co-authored-by: Goran Jelic-Cizmek <goran.jelic-cizmek@epfl.ch>
On h.quit() ensure terminal settings are same as when neuron.hoc was imported. This is most important with
NEURONMainMenu/File/Quit which would leave terminal in raw readline state with no input echoing and no return before linefeed when newline was printed. I.e. Consider the following when at the prompt, NEURONMainMenu/File/Quit is selected, and on exit, stty is typed at the terminal shell $ prompt (no echoing of stty)