Skip to content

Launching nrniv -python with Python 3.13.0 does not allow use of gui.#3239

Merged
nrnhines merged 1 commit into
masterfrom
hines/gui-readline-bug
Nov 22, 2024
Merged

Launching nrniv -python with Python 3.13.0 does not allow use of gui.#3239
nrnhines merged 1 commit into
masterfrom
hines/gui-readline-bug

Conversation

@nrnhines

Copy link
Copy Markdown
Member

Closes #3237

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (cc3acde) to head (255b339).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         569      569              
  Lines      111143   111142       -1     
==========================================
- Hits        74551    74550       -1     
  Misses      36592    36592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@azure-pipelines

Copy link
Copy Markdown

✔️ 255b339 -> Azure artifacts URL

@nrnhines nrnhines requested review from 1uc and JCGoran November 21, 2024 19:02

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this deeply, but it makes sense and fixes a real issue.

@nrnhines nrnhines merged commit 75eb334 into master Nov 22, 2024
@nrnhines nrnhines deleted the hines/gui-readline-bug branch November 22, 2024 01:17
nrnhines added a commit that referenced this pull request Mar 24, 2025
At starting point, jelic/8.2-py313 #3319 had only two CI failures.

Almost the entirety of this PR is to get 8.2 to pass CI.
In addition it supports Python3.13.
Bug fixes adopted from the master are
#3239 Launching nrniv -python with Python 3.13.0 does not allow use of gui.
#3259 On h.quit() terminal settings are same as when neuron.hoc was imported.
#3243 save stdin terminal settings on import hoc and restore on h.quit()
#3276 Python 3.13.1 broke [s for s in sl] where sl is a SectionList. Manual partial cherry-pick.

Other PR attempts at fixing CI failures that can be closed when this PR is merged, are #3329 #3325 #3319 #3317

Many of the CI fixes are backports from #3028 #3040 #3303 #3105 #3278

bldnrnmacpkgcmake.sh was updated. It isolates a change (avoid breaking CI) with -DNRN_MAC_PKG=ON
---------

Co-authored-by: Goran Jelic-Cizmek <goran.jelic-cizmek@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.13 and nrniv -python -c "from neuron import h, gui"

3 participants