Skip to content

Remove deprecated test methods#3105

Merged
1uc merged 1 commit into
masterfrom
jelic/remove_deprecated_tests
Oct 2, 2024
Merged

Remove deprecated test methods#3105
1uc merged 1 commit into
masterfrom
jelic/remove_deprecated_tests

Conversation

@JCGoran

@JCGoran JCGoran commented Oct 1, 2024

Copy link
Copy Markdown
Collaborator

In Python 3.13, some of the methods from unittest were removed.

@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2024

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ df0d3f3 -> Azure artifacts URL

@JCGoran JCGoran changed the title Remove deprecated tests Remove deprecated test methods Oct 2, 2024
@codecov

codecov Bot commented Oct 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (95cc05b) to head (df0d3f3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/tests/test_neuron.py 0.00% 1 Missing ⚠️
share/lib/python/neuron/tests/test_rxd.py 0.00% 1 Missing ⚠️
share/lib/python/neuron/tests/test_vector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3105   +/-   ##
=======================================
  Coverage   66.90%   66.91%           
=======================================
  Files         572      572           
  Lines      106671   106668    -3     
=======================================
+ Hits        71364    71372    +8     
+ Misses      35307    35296   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc merged commit a2b8b35 into master Oct 2, 2024
@1uc 1uc deleted the jelic/remove_deprecated_tests branch October 2, 2024 09:05
JCGoran pushed a commit that referenced this pull request Jan 24, 2025
nrnhines added a commit that referenced this pull request Mar 24, 2025
At starting point, jelic/8.2-py313 #3319 had only two CI failures.

Almost the entirety of this PR is to get 8.2 to pass CI.
In addition it supports Python3.13.
Bug fixes adopted from the master are
#3239 Launching nrniv -python with Python 3.13.0 does not allow use of gui.
#3259 On h.quit() terminal settings are same as when neuron.hoc was imported.
#3243 save stdin terminal settings on import hoc and restore on h.quit()
#3276 Python 3.13.1 broke [s for s in sl] where sl is a SectionList. Manual partial cherry-pick.

Other PR attempts at fixing CI failures that can be closed when this PR is merged, are #3329 #3325 #3319 #3317

Many of the CI fixes are backports from #3028 #3040 #3303 #3105 #3278

bldnrnmacpkgcmake.sh was updated. It isolates a change (avoid breaking CI) with -DNRN_MAC_PKG=ON
---------

Co-authored-by: Goran Jelic-Cizmek <goran.jelic-cizmek@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants