Fix thread sanitizer leak when launching Python 3.13 and using from neuron import h, gui.#3243
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3243 +/- ##
==========================================
- Coverage 67.08% 67.08% -0.01%
==========================================
Files 571 571
Lines 111095 111116 +21
==========================================
+ Hits 74529 74540 +11
- Misses 36566 36576 +10 ☔ View full report in Codecov by Sentry. |
|
✔️ be19ebe -> Azure artifacts URL |
JCGoran
approved these changes
Nov 22, 2024
JCGoran
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable, and it seems to fix the thread leak issue, I have only minor comments.
This comment has been minimized.
This comment has been minimized.
|
✔️ b739947 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 1bd8751 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nrnhines
commented
Nov 30, 2024
|
✔️ 78b971d -> Azure artifacts URL |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Collaborator
|
✔️ c579837 -> Azure artifacts URL |
nrnhines
added a commit
that referenced
this pull request
Mar 16, 2025
…euron import h, gui. (#3243) * nrnpython_finalize can only cleanup and Py_Finalize from MainThread * save stdin terminal settings on import hoc and restore on h.quit()
nrnhines
added a commit
that referenced
this pull request
Mar 21, 2025
…euron import h, gui. (#3243) * nrnpython_finalize can only cleanup and Py_Finalize from MainThread * save stdin terminal settings on import hoc and restore on h.quit()
nrnhines
added a commit
that referenced
this pull request
Mar 24, 2025
At starting point, jelic/8.2-py313 #3319 had only two CI failures. Almost the entirety of this PR is to get 8.2 to pass CI. In addition it supports Python3.13. Bug fixes adopted from the master are #3239 Launching nrniv -python with Python 3.13.0 does not allow use of gui. #3259 On h.quit() terminal settings are same as when neuron.hoc was imported. #3243 save stdin terminal settings on import hoc and restore on h.quit() #3276 Python 3.13.1 broke [s for s in sl] where sl is a SectionList. Manual partial cherry-pick. Other PR attempts at fixing CI failures that can be closed when this PR is merged, are #3329 #3325 #3319 #3317 Many of the CI fixes are backports from #3028 #3040 #3303 #3105 #3278 bldnrnmacpkgcmake.sh was updated. It isolates a change (avoid breaking CI) with -DNRN_MAC_PKG=ON --------- Co-authored-by: Goran Jelic-Cizmek <goran.jelic-cizmek@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.