Support cython>=3 and remove cython<3 pin.#3028
Merged
Merged
Conversation
|
✔️ 97a56b2 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Closed
1uc
previously approved these changes
Aug 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3028 +/- ##
=======================================
Coverage 67.27% 67.28%
=======================================
Files 571 571
Lines 104916 104909 -7
=======================================
Hits 70585 70585
+ Misses 34331 34324 -7 ☔ View full report in Codecov by Sentry. |
1uc
reviewed
Aug 6, 2024
cython>=3 and remove cython<3 pin.
c6d13dd to
ae2db1a
Compare
This comment has been minimized.
This comment has been minimized.
matz-e
reviewed
Aug 12, 2024
|
✔️ fcb8af5 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ c8221ee -> Azure artifacts URL |
|
|
✔️ 87a9524 -> Azure artifacts URL |
Collaborator
alkino
approved these changes
Aug 13, 2024
matz-e
approved these changes
Aug 13, 2024
1uc
approved these changes
Aug 13, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
Seems like a sensible compromise between RXD using dlsym (hence language="c") and MUSIC that uses std::vector (therefore language="c++").
mgeplf
pushed a commit
that referenced
this pull request
Aug 19, 2024
This was referenced Jan 24, 2025
nrnhines
added a commit
that referenced
this pull request
Mar 24, 2025
At starting point, jelic/8.2-py313 #3319 had only two CI failures. Almost the entirety of this PR is to get 8.2 to pass CI. In addition it supports Python3.13. Bug fixes adopted from the master are #3239 Launching nrniv -python with Python 3.13.0 does not allow use of gui. #3259 On h.quit() terminal settings are same as when neuron.hoc was imported. #3243 save stdin terminal settings on import hoc and restore on h.quit() #3276 Python 3.13.1 broke [s for s in sl] where sl is a SectionList. Manual partial cherry-pick. Other PR attempts at fixing CI failures that can be closed when this PR is merged, are #3329 #3325 #3319 #3317 Many of the CI fixes are backports from #3028 #3040 #3303 #3105 #3278 bldnrnmacpkgcmake.sh was updated. It isolates a change (avoid breaking CI) with -DNRN_MAC_PKG=ON --------- Co-authored-by: Goran Jelic-Cizmek <goran.jelic-cizmek@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2435