Android fullscreen switcher by mwoz123 · Pull Request #8 · mwoz123/koreader

mwoz123 · 2017-09-24T07:33:24Z

No description provided.

* translation text fix * quickstart(fix): go back to home dir after document close * quickstart(fix): purge old quick start files * spec: fix quickstart tests

Final fix for koreader#2502.

Includes: framebuffer_linux(fix): compare pointer properly in mmap assert

CRE cache, hyphdict and fonts can be initialized only once when first credocument is opened. Previously, they were recreated for each document, and as previous instances were probably not free'd, this caused memory leaks.

* Travis: update shfmt to v1.3.0 * better error message * fix kodev problem & fix slightly broken formatting

@poire-z

Fixes koreader#2805. Thanks to @poire-z, see koreader#2805 (comment)

Fixes koreader#2816.

@poire-z

Pointed out by @poire-z koreader@ed7937f#commitcomment-21956632

Fixes koreader#2578. * key bolded * values normally left-aligned at 50% * allows misalignment for the sake of fitting everything on one line

It makes no sense to have both, so setting a default removes the fallback, and setting a fallback removes the default. Also save hyph_alg to document setting only if it has been manually chosen, so that later changes to default or fallback can be used.

Parsing and rasterisation provided by nanosvg (some svg tags like text, span and images are not supported). Only svg image included as files in the .epub are supported (embedded svg tags in html are not). Holding on svg image shows it 4x zoomed in ImageViewer.

* Remove run twice onPageUpdate() when document is opening

* Add Greek keyboard * Fix fix raw to row in comments

…oreader#2875) * translate save as epub and close * epub to EPUB

* newsDownloader - atom support initial version * NewsDownloader: update example feed config (use Reuters atom source) * NewsDownloader: InfoMessage when unsupported urls * NewsDownloader: update menu_item id * NewsDownloader: change text label

Also allow taking screenshot when on dictionary window.

The better solution might well be to do this locally, using either ``` git config --global url."https://".insteadOf git:// ``` or ``` git config --global url."https://github.com".insteadOf git://github.com ``` However, we don't live in an ideal world so this commit intends to lower the barrier to entry. See https://stackoverflow.com/questions/16298986/unable-to-connect-to-github-com-for-cloning for more information.

Same as std keyboard with only lowercase and uppercase letters layouts adapted from QWERTY to the traditional french AZERTY layout.

@robert00s

Normal textinputs stay the same, password textinputs automatically gain a show password checkbutton underneath. Thanks to @robert00s for the idea.

So an image file can have a cover in coverbrowser's display. It also allows for an alternative viewer (ImageViewer widget) when holding on file / View full size cover.

See koreader#3107 (comment)

Brings it in line with UX guidelines.

For people who set autoremove_deleted_items_from_history to true, file is removed from history when Deleted or 'Purge .sdr'. This also update lastfile to the new top in history if needed.

* Sync LuaJIT with koreader-base at v2.1.0-beta2 koreader/android-luajit-launcher#58

Also removed OPDS `download_dir` from the candidates to Wikipedia "Save as EPUB" dir.

Fixes koreader#3069 and koreader#3116. * [fix] compile errors under Fedora due to -Werror (koreader/koreader-base#500)

Fixes koreader#3069 and koreader#3116. Add `libstc++-static package` as build prerequisite under Fedora to the README.

…n_switcher

It will introduce some minor noise, but too much stuff is simply not seen otherwise, for example: *:E ``` 02-09 12:45:53.359 2580 2609 E IconLoader: Unexpected null component name or activity info: ComponentInfo{org.koreader.launcher/org.koreader.launcher.MainActivity}, null ``` *:F ``` --------- beginning of system --------- beginning of main --------- beginning of crash 02-09 12:47:31.275 4985 5003 F libc : /home/frans/src/kobo/koreader/base/thirdparty/filemq/build/i686-linux-android-debug/filemq-prefix/src/filemq/src/fmq_client.c:170: fmq_client_set_resync: assertion "self" failed 02-09 12:47:31.275 4985 5003 F libc : Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 5003 (Thread-37), pid 4985 (reader.launcher) 02-09 12:47:31.512 5085 5085 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 02-09 12:47:31.512 5085 5085 F DEBUG : Build fingerprint: 'Android/sdk_phone_x86_64/generic_x86_64:9/PSR1.180720.012/4923214:userdebug/test-keys' 02-09 12:47:31.512 5085 5085 F DEBUG : Revision: '0' 02-09 12:47:31.513 5085 5085 F DEBUG : ABI: 'x86' 02-09 12:47:31.513 5085 5085 F DEBUG : pid: 4985, tid: 5003, name: Thread-37 >>> org.koreader.launcher <<< 02-09 12:47:31.513 5085 5085 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- 02-09 12:47:31.513 5085 5085 F DEBUG : Abort message: '/home/frans/src/kobo/koreader/base/thirdparty/filemq/build/i686-linux-android-debug/filemq-prefix/src/filemq/src/fmq_client.c:170: fmq_client_set_resync: assertion "self" failed' 02-09 12:47:31.513 5085 5085 F DEBUG : eax 00000000 ebx 00001379 ecx 0000138b edx 00000006 02-09 12:47:31.513 5085 5085 F DEBUG : edi 00000000 esi 00000000 02-09 12:47:31.513 5085 5085 F DEBUG : ebp 33167a17 esp de3e9528 eip f70d8b59 02-09 12:47:31.515 5085 5085 F DEBUG : 02-09 12:47:31.515 5085 5085 F DEBUG : backtrace: 02-09 12:47:31.515 5085 5085 F DEBUG : #00 pc 00000b59 [vdso:f70d8000] (__kernel_vsyscall+9) 02-09 12:47:31.515 5085 5085 F DEBUG : #1 pc 0001fc08 /system/lib/libc.so (syscall+40) 02-09 12:47:31.515 5085 5085 F DEBUG : #2 pc 000321f3 /system/lib/libc.so (abort+115) 02-09 12:47:31.515 5085 5085 F DEBUG : #3 pc 00032681 /system/lib/libc.so (__assert2+49) 02-09 12:47:31.515 5085 5085 F DEBUG : #4 pc 000046b0 /data/data/org.koreader.launcher/files/libs/libfmq.so.1 02-09 12:47:31.515 5085 5085 F DEBUG : #5 pc 00008e54 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #6 pc 00056a61 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #7 pc 0006ed92 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #8 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #9 pc 00061f73 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #10 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #11 pc 00061f73 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #12 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #13 pc 0001c470 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so (lua_pcall+80) 02-09 12:47:31.515 5085 5085 F DEBUG : #14 pc 0000571a /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so (android_main+458) 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#15 pc 00070a38 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#16 pc 0009cce5 /system/lib/libc.so (__pthread_start(void*)+53) 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#17 pc 00033c1b /system/lib/libc.so (__start_thread+75) ```

houqp and others added 30 commits April 24, 2017 08:27

quickstart fix (koreader#2804)

72ae808

* translation text fix * quickstart(fix): go back to home dir after document close * quickstart(fix): purge old quick start files * spec: fix quickstart tests

ota(fix): use gun tar in ubuntu touch and pocketbook

bdd0392

kobo: bump base for 32bit framebuffer fix

9af25cf

(chore) koreader.sh: remove 32-bit workaround

1850ebc

Final fix for koreader#2502.

readermenu(fix): override pan gesture from scrolling

55ec64a

Bump base/crengine for no more line wrap on no-break-space

96ea2ec

Includes: framebuffer_linux(fix): compare pointer properly in mmap assert

Reduce memory leaks when switching credocuments

495accf

CRE cache, hyphdict and fonts can be initialized only once when first credocument is opened. Previously, they were recreated for each document, and as previous instances were probably not free'd, this caused memory leaks.

Travis: update shfmt to v1.3.0 (koreader#2821)

b3a93d1

* Travis: update shfmt to v1.3.0 * better error message * fix kodev problem & fix slightly broken formatting

Fix garbled ImageWidget cache issues

fa12f48

Fixes koreader#2805. Thanks to @poire-z, see koreader#2805 (comment)

ReaderDictionary: add info message about installing dictionaries

ed7937f

Fixes koreader#2816.

Dev docs: some widgets

bb70ae9

util.lua: fix lfs require in isEmptyDir()

ea9fa95

Pointed out by @poire-z koreader@ed7937f#commitcomment-21956632

KeyValuePage: improve looks

4616339

Fixes koreader#2578. * key bolded * values normally left-aligned at 50% * allows misalignment for the sake of fitting everything on one line

KeyValuePage: smaller font and padding

19928f2

Font: unify font styling

e1aa57f

(chore) some require sorting.

773e24f

Fix crash on Swipe to follow links with DJVU documents

3b813c7

Remove run twice onPageUpdate() when document is opening (koreader#2855)

394be8a

* Remove run twice onPageUpdate() when document is opening

DevDocs: ui.downloadmgr

e7f4af1

Add Greek keyboard (koreader#2866)

0b47c81

* Add Greek keyboard * Fix fix raw to row in comments

chore: style cleanup for infomessage

23c2955

goodreads(fix): double free

3541320

goodreads(fix): remove incorrect image_disposable setting

6d3349d

minor: translate "Save as epub" and "Close" in full Wikipedia window (k…

f21550b

…oreader#2875) * translate save as epub and close * epub to EPUB

wifi(fix): quote ssid and password for wpa_passphrase

bde2139

build(fix): fail release command by default if make po failed

b33c926

Allow wikipedia lookup from filemanager

9e346f5

Also allow taking screenshot when on dictionary window.

robert00s and others added 26 commits August 19, 2017 21:21

Added french keyboard

a074876

Same as std keyboard with only lowercase and uppercase letters layouts adapted from QWERTY to the traditional french AZERTY layout.

[fix] wbuilder crash

9f3ec23

[UX] Add CheckButton and use it for show password

63241a2

Normal textinputs stay the same, password textinputs automatically gain a show password checkbutton underneath. Thanks to @robert00s for the idea.

Added PicDocument:getCoverPageImage() and :getProps()

031df2f

So an image file can have a cover in coverbrowser's display. It also allows for an alternative viewer (ImageViewer widget) when holding on file / View full size cover.

[fix] MenuSorter: ignore separator as first item

4513718

See koreader#3107 (comment)

[fix] InputText: dirty dimensions

e23c2fd

Bump base; fixes koreader#914

1f75bc6

[UX] ReaderUI: save/don't save document instead of yes/no

c8ab918

Brings it in line with UX guidelines.

Update 'lastfile' if autoremove_deleted_items_from_history

9c08236

For people who set autoremove_deleted_items_from_history to true, file is removed from history when Deleted or 'Purge .sdr'. This also update lastfile to the new top in history if needed.

Bump android-luajit-launcher

abaa699

* Sync LuaJIT with koreader-base at v2.1.0-beta2 koreader/android-luajit-launcher#58

Added Dictionary settings and Wikipedia settings menus (koreader#3121)

5d2bebc

Also removed OPDS `download_dir` from the candidates to Wikipedia "Save as EPUB" dir.

Use checkmarks with Set render style items (koreader#3122)

7284ad4

Bump base (koreader#3124)

bd096de

Fixes koreader#3069 and koreader#3116. * [fix] compile errors under Fedora due to -Werror (koreader/koreader-base#500)

[fix] Add libstc++-static package to README (koreader#3125)

0dcdb28

Fixes koreader#3069 and koreader#3116. Add `libstc++-static package` as build prerequisite under Fedora to the README.

Move PluginShare.backgroundJobs into PluginShare module (koreader#3128)

b89435b

Add some settings to Display mode/Other settings menu (koreader#3129)

2595dbb

Avoid settings double save when leaving Reader (koreader#3131)

17014f9

Merge remote-tracking branch 'upstream/master' into Android_Fullscree…

c0f560e

…n_switcher

[w.i.p] fullscreen tring different solutions

25452c5

Android fullscreen switcher: working switcher

5a08e11

fix luacheck complains

2b4510e

Android Fullscreen switcher: code review changes

fbe1168

Android Fullscreen switcher: code review changes2

2f33559

Android Fullscreen switcher: code review changes3

e7aa836

Merge branch 'master' into Android_Fullscreen_switcher

004d47a

mwoz123 merged commit f7cb369 into master Sep 24, 2017

mwoz123 deleted the Android_Fullscreen_switcher branch October 28, 2017 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android fullscreen switcher#8

Android fullscreen switcher#8
mwoz123 merged 177 commits intomasterfrom
Android_Fullscreen_switcher

mwoz123 commented Sep 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

mwoz123 commented Sep 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants