Dictionary settings and Wikipedia settings menu items#3121
Dictionary settings and Wikipedia settings menu items#3121Frenzie merged 1 commit intokoreader:masterfrom
Conversation
7b437e3 to
4da1415
Compare
I shouldn't think so. It's quite convenient not to have to navigate to the same folder over and over again if you're grabbing a few books at once. However, when selecting a download folder in my browser (which opens where I last downloaded on a per-site basis, quite convenient) then I also have a means of quickly browsing to my bookmarked folders. I think that's the biggest missing feature in the relevant widget, although at least on my ereader with a few reasonably well-sorted folders without a huge amount of levels it's never exceeded my annoyance threshold.
Bookmarks in filemanager is already tracked somewhere if I'm not mistaken, and something like "go to home" is somewhere on my personal mental backlog if nowhere else. |
Frenzie
left a comment
There was a problem hiding this comment.
a couple of comments on style
| end, | ||
| }, | ||
| { -- setting used by dictquicklookup | ||
| text = _("Justify definitions' text"), |
There was a problem hiding this comment.
Justify text is probably enough.
| else | ||
| -- We don't create more than one directory, in case of bad input | ||
| UIManager:show(InfoMessage:new{ | ||
| text = _("Parent directory does not exist, please create intermediate directories first.") |
| input = curr_languages, | ||
| input_hint = "en fr zh", | ||
| input_type = "text", | ||
| description = _("Enter one or more wikipedia language codes (the 2 or 3 letters before .wikipedia.org), in the order you wish to see them available, separated by space(s) (ie: en fr zh)\nFull list at https://en.wikipedia.org/wiki/List_of_Wikipedias"), |
There was a problem hiding this comment.
- Missing capitalization in
wikipedia i.e.,or justexample:The fact that I use cf. and i.e. constantly just means I read a fair amount of academic material. :-P
| }) | ||
| else | ||
| UIManager:show(InfoMessage:new{ | ||
| text = _("Failed creating directory.") |
There was a problem hiding this comment.
creating directory failed (or "failed at creating directory" would also be grammatically correct, though stylistically somewhat awkward)
| input = dir, | ||
| input_hint = default_dir, | ||
| input_type = "text", | ||
| description = _("Enter the full path of a directory."), |
|
So, no problem with mixing OPDS books with wikipedia articles ? I don't use OPDS, so I dunno how people would feel. Thought saving directly into home_dir would be best.
|
|
Sorry, I misunderstood. I suppose the OPDS download dir doesn't really have anything to do with the Wikipedia "Save as EPUB" functionality. |
|
The OPDS download directory could be different for each file downloaded, it is selectable for each download. ( One might be destined for my "Polyticks" folder and the next into Fantasy or SciFi.) You might want to use the same approach for WiKi article placement into the directory structure. |
Also removed OPDS download_dir from the candidates to Wikipedia Save as EPUB dir.
4da1415 to
99ffee1
Compare
|
Thanks., Wording corrected. Just discovering there is a frontend/ui/downloadmgr.lua and a frontend/ui/widget/pathchooser (used by OPDS app). |
Added 2 submenus, and some settings menu items I was too lazy to add some months ago.
Dictionary settings: movedDisable dictionary fuzzy searchin it, and addedJustify definitions' text(we may add later some other items like list dictionary, dictionary management and ordering...)Wikipedia settings: addedSet Wikipedia languages(free input of language codes separated by space) andSet Wikipedia 'Save as EPUB' directory.Should I remove
download_dir(directory configured for OPDS downloads) from the candidates forSave as EPUB, so candidates starts withhome_dirorgetDefaultDir()?