Merge by mwoz123 · Pull Request #11 · mwoz123/koreader

mwoz123 · 2017-11-04T18:34:18Z

No description provided.

Prevent visibility of readers's footer edges.

And unrelated small optimisation in imagewidget

+ reorganize config, improved comments

* Cache scaled images with scale_for_dpi * Don't update original self.scale_for_dpi A same ImageWidget object can be free()'d and re-render()ed, and we would then lose scale_for_dpi on next renderings

Bump base for versioned Android libs. Fixes #3214. Fixes #3112. Fixes #3091. Fixes #3039. Fixes #2976. Fixes #2960. Fixes #2947.

Tap to go HOME. Hold to set current folder as HOME. When no HOME is set yet tap also asks to set current folder as HOME. See #2957 (comment) Closes #3200.

See #3214 (comment) and #3118 (comment)

@KenMaltby

I was reminded by @KenMaltby that this is disabled on Android. https://www.mobileread.com/forums/showthread.php?p=3586162#post3586162

Closes: #3236 and #3235 Details: > Also, when looking in days, we see info how many hours we read. It would be great if we could tap a day, it opens info on book(s) we read that day with info pertaining to that day, and if we tap on book, we receive book info for that book. > Statistics plugin is really great, I started to look in my reading statistics now much more, but all the time I can go only in one way. And I need to exit at lowest level of info. It would be great if I can use statistics plugin like part of menu, to go up and down within statistics data and exit at my wish, not when I have to. Also added: * new statistics book by week * new statistics book by month * last year by week now we can see days in selected week

For years they've been smaller on higher DPI devices and likely very few people realized it was technically a bug. These values round up on lower DPI and smaller screen devices. References #3265

Also fix path display update. Fixes #3270.

We previously disabled cache, but that may cause excessive memory usage with big books. We now use a temporary cache directory, that we clean when no more needed.

* Allow for colored rendering Available with all engines (CRE, PDF, Images). Needs to manually add setting: "color_rendering" = true * Disable color for djvudocument * Use Screen:isColorEnabled() * Bump base

See #2878 (comment) Also fix `./kodev run -h` as alias for `--help` as it's always overwritten by `-h` in the sense of the much more important `--screen-height`.

New menu item in Screen submenu. hasColorScreen enabled for SDL device.

…mance improvements (#3430)

Upstream uses `-e` rather than the `-f` that was first introduced in our fork. References #3429 (comment)

… full web page (#3426) Fixes #3425.

Fixes #3408.

Otherwise it didn't pick up on the -debug suffix.

Implemented through the Android API so it's reasonably cheap.

…iles (#3445)

For: * [fix] filter out more bad lines in wpa scan result (koreader/lj-wpaclient#3) Fixes #3436

Apply junit testcase time fix so CircleCI can actually do something useful with the results. This can be removed once there is a busted 2.0.rc13 or final See lunarmodules/busted@830f175

+ Fix height for ToggleWidget + Able ToggleWidget width more than half of width of screen

Close: #2133 More info: #2133

It will introduce some minor noise, but too much stuff is simply not seen otherwise, for example: *:E ``` 02-09 12:45:53.359 2580 2609 E IconLoader: Unexpected null component name or activity info: ComponentInfo{org.koreader.launcher/org.koreader.launcher.MainActivity}, null ``` *:F ``` --------- beginning of system --------- beginning of main --------- beginning of crash 02-09 12:47:31.275 4985 5003 F libc : /home/frans/src/kobo/koreader/base/thirdparty/filemq/build/i686-linux-android-debug/filemq-prefix/src/filemq/src/fmq_client.c:170: fmq_client_set_resync: assertion "self" failed 02-09 12:47:31.275 4985 5003 F libc : Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 5003 (Thread-37), pid 4985 (reader.launcher) 02-09 12:47:31.512 5085 5085 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 02-09 12:47:31.512 5085 5085 F DEBUG : Build fingerprint: 'Android/sdk_phone_x86_64/generic_x86_64:9/PSR1.180720.012/4923214:userdebug/test-keys' 02-09 12:47:31.512 5085 5085 F DEBUG : Revision: '0' 02-09 12:47:31.513 5085 5085 F DEBUG : ABI: 'x86' 02-09 12:47:31.513 5085 5085 F DEBUG : pid: 4985, tid: 5003, name: Thread-37 >>> org.koreader.launcher <<< 02-09 12:47:31.513 5085 5085 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- 02-09 12:47:31.513 5085 5085 F DEBUG : Abort message: '/home/frans/src/kobo/koreader/base/thirdparty/filemq/build/i686-linux-android-debug/filemq-prefix/src/filemq/src/fmq_client.c:170: fmq_client_set_resync: assertion "self" failed' 02-09 12:47:31.513 5085 5085 F DEBUG : eax 00000000 ebx 00001379 ecx 0000138b edx 00000006 02-09 12:47:31.513 5085 5085 F DEBUG : edi 00000000 esi 00000000 02-09 12:47:31.513 5085 5085 F DEBUG : ebp 33167a17 esp de3e9528 eip f70d8b59 02-09 12:47:31.515 5085 5085 F DEBUG : 02-09 12:47:31.515 5085 5085 F DEBUG : backtrace: 02-09 12:47:31.515 5085 5085 F DEBUG : #00 pc 00000b59 [vdso:f70d8000] (__kernel_vsyscall+9) 02-09 12:47:31.515 5085 5085 F DEBUG : #1 pc 0001fc08 /system/lib/libc.so (syscall+40) 02-09 12:47:31.515 5085 5085 F DEBUG : #2 pc 000321f3 /system/lib/libc.so (abort+115) 02-09 12:47:31.515 5085 5085 F DEBUG : #3 pc 00032681 /system/lib/libc.so (__assert2+49) 02-09 12:47:31.515 5085 5085 F DEBUG : #4 pc 000046b0 /data/data/org.koreader.launcher/files/libs/libfmq.so.1 02-09 12:47:31.515 5085 5085 F DEBUG : #5 pc 00008e54 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #6 pc 00056a61 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #7 pc 0006ed92 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #8 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #9 pc 00061f73 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #10 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #11 pc 00061f73 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #12 pc 00006fc9 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : #13 pc 0001c470 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so (lua_pcall+80) 02-09 12:47:31.515 5085 5085 F DEBUG : #14 pc 0000571a /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so (android_main+458) 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#15 pc 00070a38 /data/app/org.koreader.launcher-u3tYrWEK7wgvoJGvd1pTrA==/lib/x86/libluajit.so 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#16 pc 0009cce5 /system/lib/libc.so (__pthread_start(void*)+53) 02-09 12:47:31.515 5085 5085 F DEBUG : koreader#17 pc 00033c1b /system/lib/libc.so (__start_thread+75) ```

robert00s and others added 30 commits September 24, 2017 13:03

Timer Reader with normal time format (#3244)

88aba42

[fix, UX] Remove rounded corners from fullscreen History (#3256)

2735c6d

Prevent visibility of readers's footer edges.

[UX] Smaller bottom menu icons (#3257)

9448a52

And unrelated small optimisation in imagewidget

Adapt ND to changes in code where 0 means no limit (#3258)

e7da93d

+ reorganize config, improved comments

Bump base for smoother image scaling (#3259)

a2b0fb2

README: fix typo

35be7c0

ImageWidget: use MuPDF for scaling images (#3260)

0aa0b9b

* Cache scaled images with scale_for_dpi * Don't update original self.scale_for_dpi A same ImageWidget object can be free()'d and re-render()ed, and we would then lose scale_for_dpi on next renderings

[fix] Some Android issues (#3262)

6275453

Bump base for versioned Android libs. Fixes #3214. Fixes #3112. Fixes #3091. Fixes #3039. Fixes #2976. Fixes #2960. Fixes #2947.

[UX] Add home button (#3263)

0fc5a37

Tap to go HOME. Hold to set current folder as HOME. When no HOME is set yet tap also asks to set current folder as HOME. See #2957 (comment) Closes #3200.

[fix, Android] restore patch.lua and fix odd anonymous function issue

94c0e01

See #3214 (comment) and #3118 (comment)

[Android] Enable CoverBrowser (#3264)

ff3ca5d

I was reminded by @KenMaltby that this is disabled on Android. https://www.mobileread.com/forums/showthread.php?p=3586162#post3586162

[UX] Smaller borders (#3266)

35af912

For years they've been smaller on higher DPI devices and likely very few people realized it was technically a bug. These values round up on lower DPI and smaller screen devices. References #3265

README: update Android NDK/SDK info

ac02d15

[fix] Avoid crash when set home (#3269)

af356a8

README: various style, grammar, clarifications & updates

5da6624

[fix] Add hold_callback to IconButton (#3271)

0d7999e

Also fix path display update. Fixes #3270.

CoverBrowser: use MuPDF for down-scaling images (#3272)

48d888b

README: more grammar

994606e

README: update info about screen size/DPI

a3ae461

README: typo and grammar

7da2998

CoverBrowser: use a cache for crengine books extraction (#3277)

e350e0e

We previously disabled cache, but that may cause excessive memory usage with big books. We now use a temporary cache directory, that we clean when no more needed.

Rename bookmark (#3275)

a2ea46b

Allow for colored rendering (#3276)

180f575

* Allow for colored rendering Available with all engines (CRE, PDF, Images). Needs to manually add setting: "color_rendering" = true * Disable color for djvudocument * Use Screen:isColorEnabled() * Bump base

[lang] OPDSCatalog ConfirmBox ok_text/cancel_text (#3281)

3dfbd3b

Fix refresh in Time range (#3278)

7323d04

kodev: run with catchsegv by default (#3283)

3a96517

See #2878 (comment) Also fix `./kodev run -h` as alias for `--help` as it's always overwritten by `-h` in the sense of the much more important `--screen-height`.

Time reader with normal time format v2 (#3279)

f45188f

Allow for toggling color rendering

53f083f

New menu item in Screen submenu. hasColorScreen enabled for SDL device.

Enable color rendering on Android

92e0067

poire-z and others added 27 commits October 23, 2017 21:17

[UX] Fix dict title width to not go over CloseButton (#3414)

3639c3e

Wiki save as epub: close highlight menu when switching document (#3417)

99161d6

separate strings for singular and plural (#3420)

e1019ba

Bump base (sdcv -u patch for android again) (#3421)

e8aeb3c

DataStorage: also create data/tessdata and minor string concat perfor…

8bc2b8d

…mance improvements (#3430)

[fix] Dictionary no fuzzy search flag (#3433)

2ddcc71

Upstream uses `-e` rather than the `-f` that was first introduced in our fork. References #3429 (comment)

NewsDownloader: use feed.description as news context instead download…

97a72e2

… full web page (#3426) Fixes #3425.

Bump base (updated libk2pdfopt) (#3437)

f675817

kodev: add assert_ret_zero after make android-ndk (#3438)

97aee14

Fixes #3408.

[build] Add -debug suffix to KODEBUG builds (#3439)

9000ed1

NewsDownloader: Remove NewsDownloader files from history (#3424)

424593c

kodev: added setup_env to run android

d3a8338

Otherwise it didn't pick up on the -debug suffix.

Bump android-luajit-launcher

575fc82

[Android] Wifi status in footer (#3396)

a01271b

Implemented through the Android API so it's reasonably cheap.

NewsDownloader: wifi off prompt after download (#3395)

c2bed63

[UX] Improve ConfigDialog (#3443)

369cf4f

[CI] Also run coverage on plugins (#3447)

1ba316a

NewsDownloader: Compatibility for users with previous configuration f…

456e31a

…iles (#3445)

Bump base (fix wpa crash by @civalin) (#3449)

d212b47

For: * [fix] filter out more bad lines in wpa scan result (koreader/lj-wpaclient#3) Fixes #3436

[CI] apply patch for busted junit testcase time (#3450)

72235cf

Apply junit testcase time fix so CircleCI can actually do something useful with the results. This can be removed once there is a busted 2.0.rc13 or final See lunarmodules/busted@830f175

[fix, CI] silly typo in busted junit output patch

dbd9348

README: tiny grammar fix (#3453)

69ec93d

ConfigDialog improvements 2 (#3455)

198c151

+ Fix height for ToggleWidget + Able ToggleWidget width more than half of width of screen

[fix] Disable Highlight button when text is not selected (#3457)

1785551

i10n/README: small stylistic changes

d149ca9

doc/Unit tests: minor extra explanation (#3462)

032d1af

More contrast settings (#3463)

0def547

Close: #2133 More info: #2133

mwoz123 merged commit 5df83d6 into mwoz123:master Nov 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge#11

Merge#11
mwoz123 merged 153 commits intomwoz123:masterfrom
koreader:master

mwoz123 commented Nov 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

mwoz123 commented Nov 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants