Add some settings to Display mode/Other settings menu#3129
Add some settings to Display mode/Other settings menu#3129Frenzie merged 1 commit intokoreader:masterfrom
Conversation
|
Did you consider using a menu sort order so that the plugin part will automatically be left out without the plugin? |
|
No, I didn't. You're thinking about making these available also for android devices where coverbrowser is disabled? edit: Not involving menu sorter, it could be easier to, even for android, |
|
You'd add another entry in the menu_order definition: filemanager_display_mode = {
"plugin_stuff",
"more_plugin_stuff",
"----------------------------",
-- the above will simply be ignored by MenuSorter if plugin_stuff is nil
"core_stuff",
"more_core_stuff",
},I spent most of my time on MenuSorter making sure it could deal with such situations without breaking (except I never thought to throw the separator thing at it). Most submenus are done the traditional way but in principle many of them could be migrated to the MenuSorter system, even if only internally. That is, you could define your own menu using the MenuSorter method while still keeping it out of the main loop. plugin_menu_order = {} -- you know how this works
plugin_menu.whatever = {text="etc"}
menu_items.my_plugin_name = MenuSorter:sort(plugin_menu, plugin_menu_order)In fact that might be preferable to keep plugin configuration separate. On the flip side, in that case you can't reorganize the entire menu at your personal whim. Anyway, those are just some possibilities I explicitly designed in there but which aren't currently used much if at all. :-) |
Something like "filemanager (display) settings"? |
1a6ea87 to
2f215db
Compare
|
OK, made that menu with new 3 settings at 1st level named File browser settings on Android. It still itches me a bit that this core settings menu is defined here in a plugin. They could probably be in filemanagermenu.lua, (as No rewording suggestions ? |
| separator = true, | ||
| }, | ||
| { | ||
| text = _("Abbreviate home directory with ~"), |
There was a problem hiding this comment.
How about Shorten home directory to ~?
| end, | ||
| }, | ||
| { | ||
| text = _("List with image and metadata"), |
There was a problem hiding this comment.
List with images and metadata (or maybe Detailed list with images/thumbnails)
| end, | ||
| }, | ||
| { | ||
| text = _("List with metadata, no image"), |
There was a problem hiding this comment.
Same here, plural sounds better
| end, | ||
| }, | ||
| { | ||
| text = _("List with image and filename"), |
There was a problem hiding this comment.
and finally images and filenames
|
As you wish. :-P |
|
Tried to put them into filemanagermenu.lua, but plugins/registered_widgets are added eartly to menu, before menu's own stuff, so in this plugin's Updated wordings (including those from original coverbrowser not noticed weeks ago :). (The "file changed" diff is a bit ugly, because I gain one indentation level by using |
That would depend on context. When in doubt you can always check on one of those sites like Linguee or Bab.la. They've usually got fairly decently translated stuff. http://www.linguee.fr/francais-anglais/search?source=auto&query=aucune+image For example, you've got this pair:
(… nintendo.ru? Odd to get English from there, but whatever) I think that in English zero probably always takes a plural form, unless it's a mass noun like sand or water. Of course you could always say that you don't have even a single image when you have pas d'images. :-P Speaking of which, what's the difference between J'ai aucune image and Je n'ai pas d'images? To me the first sounds more forceful. |
|
OK, so "no images" can stay.
No real difference, and you're right about the forceful (and we use the negative in je n'ai aucune image) |
It seems to me that even the n' is often dropped outside of writing.. ;-) But yes, that was a silly oversight on my part. Double negatives don't come naturally. I've managed to internalize a few of the most common ones like ne…pas, ne…plus and ne…jamais so they come out without thinking but that's about it. |
Yes indeed, in talking, we easily drop the |
Some hidden file manager settings may have a place in menu, and they may fit in the newly added Display mode/Other settings menu (from coverbrowser plugin).
From #2589 (comment) :
show_file_in_bold filemanager items in bold : true/false/"opened" #2457
home_dir_display_name used by filemanagerutil.abbreviate(path) to shorten directory in title bar made as a toggle (true => "~", false => nil) (people who wants something other than ~ may set it manually as before
autoremove_deleted_items_from_history #2583 (comment)
This menu comes from coverbrowser plugin, so it may look strange to deal with core settings there, but it fits the menu hierarchy.
The first one has a real place there. It's not too obvious for the other 2, but better to have them burried there that not available, no ?
Was tempted to add there auto_book_status (show book status onEndOfBook) but it feels really out of place as it's about reader. No obvious place for it on Reader side, it does not deserve a first-level item, may be in a "Other settings" subitem ?
(
separator=truemoved just for logical reason: as it's displayed after an item, better for it to be at bottom of item definition)