Prevent problem with git clone#3094
Conversation
|
Yes, I found the similar these days. Maybe github drops http support. |
|
P.S. are all the URLs updated? |
|
This doesn't seem like a good idea to me. The second answer seems better to me if local overrides are desired for some reason. https://stackoverflow.com/a/18889129/2470572 You can also change your SSH config to run over the HTTPS port: https://help.github.com/articles/using-ssh-over-the-https-port/ @Hzj-jie Most URLs everywhere are git:// as they should be, at least in base. |
|
Hm, you're right. Just the ones I've looked at recently are git:// Btw I don't know if GitLab is a good example But these are too https://github.com/koreader/koreader-base/blob/3e9b63f5cafc12335e18ea8ed313aa01c004b745/.gitmodules (sdcv, mupdf, luafilesystem, djvulibre, crengine, libk2pdfopt, freetype, and possibly others) On the one hand as long as it's only meant for checking out it doesn't really matter, but on the other hand it might give people the wrong idea about how to clone repos for contributing. Not sure what to think. |
|
Alright, I thought about it and I've concluded I didn't give sufficient weight to lowering the barrier to entry (however little). But note that this PR will require a follow-up in base for the repos I mentioned above if not more. |
We should use https://github.com/koreader/... instead of git://github.com/koreader/... to prevent such problems: https://stackoverflow.com/questions/16298986/unable-to-connect-to-github-com-for-cloning
I have today similar problem.