Skip to content

Prevent problem with git clone#3094

Merged
Frenzie merged 1 commit intokoreader:masterfrom
robert00s:git_https
Aug 19, 2017
Merged

Prevent problem with git clone#3094
Frenzie merged 1 commit intokoreader:masterfrom
robert00s:git_https

Conversation

@robert00s
Copy link
Copy Markdown
Contributor

We should use https://github.com/koreader/... instead of git://github.com/koreader/... to prevent such problems: https://stackoverflow.com/questions/16298986/unable-to-connect-to-github-com-for-cloning
I have today similar problem.

@Hzj-jie
Copy link
Copy Markdown
Contributor

Hzj-jie commented Aug 17, 2017

Yes, I found the similar these days. Maybe github drops http support.

@Hzj-jie
Copy link
Copy Markdown
Contributor

Hzj-jie commented Aug 17, 2017

P.S. are all the URLs updated?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 17, 2017

This doesn't seem like a good idea to me. The second answer seems better to me if local overrides are desired for some reason.

https://stackoverflow.com/a/18889129/2470572

You can also change your SSH config to run over the HTTPS port: https://help.github.com/articles/using-ssh-over-the-https-port/

@Hzj-jie Most URLs everywhere are git:// as they should be, at least in base.

@robert00s
Copy link
Copy Markdown
Contributor Author

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 17, 2017

Hm, you're right. Just the ones I've looked at recently are git:// Btw I don't know if GitLab is a good example

But these are too https://github.com/koreader/koreader-base/blob/3e9b63f5cafc12335e18ea8ed313aa01c004b745/.gitmodules (sdcv, mupdf, luafilesystem, djvulibre, crengine, libk2pdfopt, freetype, and possibly others)

On the one hand as long as it's only meant for checking out it doesn't really matter, but on the other hand it might give people the wrong idea about how to clone repos for contributing. Not sure what to think.

@Frenzie Frenzie merged commit a2320d2 into koreader:master Aug 19, 2017
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Aug 19, 2017

Alright, I thought about it and I've concluded I didn't give sufficient weight to lowering the barrier to entry (however little). But note that this PR will require a follow-up in base for the repos I mentioned above if not more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants