-
Notifications
You must be signed in to change notification settings - Fork 75
Merge dev into master #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge merge commits.
Added metadata for April 2018 client library updates.
We need to generate POST/PATCH/DELETE for (I)EntityWithReferenceRequest. A few of the base template methods did not have toggles for collection property initialization, so I added them where appropriate but set them to true by default, so it should not affect existing generated code.
…te-method Add DELETE/POST/PATCH to (I)EntityWithReferenceRequest
…models related files.
Merge pull request #132 from microsoftgraph/fixWithRefRequest Fixes generation issue for reference request
… generate correct import statement
added metadata for 2018-05-15
Fixing templates for java model generated files import statement for …
…template generates ~200 files and helps improve memory footprint for java sdk.
… template generates ~400 files and helps improve memory footprint for java sdk
Fixing BaseMethodBody java template files to use import statements co…
Java template fix to reduce memory footprint - continued
…e generates ~450 files. After this change, java sdk builds with 3.5GB RAM
…te generates ~450 files. After this change, java sdk with generated files builds with 3GB RAM.
…emplate generates ~200 files.
Java template fix to reduce memory footprint - continued
…ate generates ~600 files.
Java template fix to reduce memory footprint - continued
…nerates ~600 files.
…enerates ~600 files.
…method for IBaseMethodRequest
…enerates ~200 files.
…ode-Generator into extensions-generated-java-merging
…-merging Extensions-generated java merging
deepak2016
previously approved these changes
Jan 24, 2019
Sanitize Parameter variables to fix errors
Contributor
|
We should discuss in triage tomorrow why we have dev and master. It's not clear to me. |
darrelmiller
previously approved these changes
Jan 30, 2019
Now allows GetSanitizedPropertyName to accept an additional parameter, suffix, so that an additional string may be concatenated onto the end of the Property. Updated method logic to look for and concatenate suffix when specified.
Updates IEntityRequestBuilder.Base.template.tt so that it does not create properties with the same name as the methods within the class (specifically request), by concatenating a "_" to the end of the property name.
Updates EntityRequestBuilder.Base.template.tt so that it does not create properties with the same name as the methods within the class (specifically request), by concatenating a "_" to the end of the property name.
Vidadhee/objc model gen
Deletes invalid reference paths to avoid namespace errors
Fix build errors for same method and property name Validated that this does not affect existing generation for .Net classes.
…GraphClientModels file and relevant imports
* Added a test for validating custom PHP namespace property from the TypeWriter CLI. Fixed test metadata. * Add support for specifying key-value properties from the Typewriter CLI. * Fix broken tests. * Updated test metadata to match preprocessing * Changes support E2E testing when different target platforms are used in a test run for Typewriter. The TemplateProcessor host needs to be reset for the case when we target a new language. Otherwise the wrong *CodeWriter will be used and an unsupported cast will occur in the templates when trying to cast host.CodeWriter to the platform specific CodeWriter. The change to ConfigurationService.Settings is also required to reset the settings for configuring the TemplateWriter. * Updated typewriter tests to be more descriptive
Change Models template to ClientModels for ObjC
MIchaelMainer
added a commit
that referenced
this pull request
Feb 12, 2019
Merge pull request #171 from microsoftgraph/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't merged in a while which indicates that we may want to consider getting rid of either master or dev.