Skip to content

Fix with ref request #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MIchaelMainer merged 2 commits into from
May 29, 2018
Merged

Fix with ref request #132

MIchaelMainer merged 2 commits into from
May 29, 2018

Conversation

@MIchaelMainer
Copy link
Collaborator

@MIchaelMainer MIchaelMainer commented May 24, 2018

Fixes issue introduced with #131

Was causing the following issue at generation time.

11:25:29 Microsoft.Graph.ODataTemplateWriter.TemplateProcessor.TemplateProcessor Error(0): d:\repos\MSGraph-SDK-Code-Generator\Templates\CSharp\Requests\IEntityWithReferenceRequest.cs.tt(22,64) : error CS1501: No overload for method 'GetEntityGetAsyncMethod' takes 2 arguments
11:25:30 Microsoft.Graph.ODataTemplateWriter.TemplateProcessor.TemplateProcessor Error(1): d:\repos\MSGraph-SDK-Code-Generator\Templates\CSharp\Requests\IEntityWithReferenceRequest.cs.tt(24,64) : error CS1501: No overload for method 'GetEntityCreateAsyncMethod' takes 2 arguments
11:25:30 Microsoft.Graph.ODataTemplateWriter.TemplateProcessor.TemplateProcessor Error(2): d:\repos\MSGraph-SDK-Code-Generator\Templates\CSharp\Requests\IEntityWithReferenceRequest.cs.tt(26,64) : error CS1501: No overload for method 'GetEntityUpdateAsyncMethod' takes 2 arguments
11:25:30 VIPR System.InvalidOperationException: Template error.
   at ........

@MIchaelMainer MIchaelMainer requested a review from a team May 24, 2018 18:31
@MIchaelMainer
Copy link
Collaborator Author

MIchaelMainer commented May 24, 2018

@microsoftgraph/sdk-reviewers Whenever we have changes to a template in one language, we always need to investigate whether we need to make a similar change for the templates for the other platforms. So in this case, @deepak2016 the same issue doesn't appear to be present in the Android or Java templates. With that said, we typically want to generate after a template change to understand the impact on the generated file set.

deepak2016
deepak2016 approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@deepak2016 deepak2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@deepak2016
Copy link
Contributor

deepak2016 commented May 29, 2018

Thanks for the information about the process @MIchaelMainer

@MIchaelMainer MIchaelMainer merged commit 91f1248 into dev May 29, 2018
@MIchaelMainer MIchaelMainer deleted the fixWithRefRequest branch May 29, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@deepak2016 deepak2016 deepak2016 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MIchaelMainer @deepak2016