Skip to content

Conversation

@NakulSabharwal
Copy link

@NakulSabharwal NakulSabharwal commented Jan 21, 2019

  • Edited templates to remove Extensions template.
  • Removed requests_generated folder.
  • Added custom code in request classes in IClient.java.tt, BaseEntityCollectionRequestBuilder.java.tt, BaseEntityRequestBuilder.java.tt, Client.java.tt and IBaseEntityRequestBuilder.java.tt.
  • Changed class name mapping in CustomOverites.

Copy link
Contributor

@deepak2016 deepak2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the customOverwrites supposed to work? Also, can you share an example generated file?

@NakulSabharwal
Copy link
Author

NakulSabharwal commented Jan 23, 2019

@MIchaelMainer In BaseOnenotePageCollectionRequest
public void post(final OnenotePage newOnenotePage, final ICallback<OnenotePage> callback) {
is replaced with
public void post(final byte[] newOnenotePage, final ICallback<OnenotePage> callback) {
gen.zip
The newer folder shows that what will be directory stucture and class contents now.

@MIchaelMainer
Copy link
Collaborator

I don't see the overwrite in OnenotePageCollectionRequest. Perhaps I'm missing something here.

image

One issue I do see are the namespace imports instead of only importing the required resources:

import com.microsoft.graph.concurrency.;
import com.microsoft.graph.core.
;
import com.microsoft.graph.models.;
import com.microsoft.graph.http.
;
import com.microsoft.graph.requests.;
import com.microsoft.graph.options.
;
import com.microsoft.graph.serializer.*;
import java.util.Arrays;
import java.util.EnumSet;

Let's put this in another PR.

Copy link
Collaborator

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix namespace imports in another PR.

@deepak2016 deepak2016 merged commit 2a392f0 into dev Jan 24, 2019
@MIchaelMainer MIchaelMainer deleted the extensions-generated-java-merging branch February 12, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants