-
Notifications
You must be signed in to change notification settings - Fork 75
Extensions-generated java merging #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cture of folders.
…ode-Generator into extensions-generated-java-merging
…for response collection class name.
…ode-Generator into extensions-generated-java-merging
deepak2016
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
MIchaelMainer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the customOverwrites supposed to work? Also, can you share an example generated file?
|
@MIchaelMainer In BaseOnenotePageCollectionRequest |
|
I don't see the overwrite in OnenotePageCollectionRequest. Perhaps I'm missing something here. One issue I do see are the namespace imports instead of only importing the required resources: import com.microsoft.graph.concurrency.; Let's put this in another PR. |
MIchaelMainer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix namespace imports in another PR.

Uh oh!
There was an error while loading. Please reload this page.