Sanitize Parameter variables to fix errors #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hi @JaapSingh Thanks for your contribution. It is much appreciated. Your change seems to make sense to me. However, it would be great if you could add a short description of the problem you ran into and how using the sanitize solves the problem for you. Thanks! |
PxlBuzzard
approved these changes
Jan 29, 2019
Contributor
|
@MIchaelMainer If you are good with this fix, feel free to merge. |
MIchaelMainer
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the SDK, certain parameter names were not being sanitized, which resulted in errors such as myfunc(string string), as opposed to myfunc(string @string). To fix this, I sanitized the parameter .