Fixing BaseMethodBody java template files to use import statements co… #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelMainer
approved these changes
Jun 21, 2018
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Is there any reason to keep CreatePackageDef(host) in BaseJavaModel.template.tt? If not, let's delete it.
Contributor
Author
|
Yes, it is being used by other templates which we have not fixed. This is the method which adds generic import statements in all files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrectly
This is part of the effort to reduce memory footprint for java sdk. As per the findings, generic import statements are contributing to large memory usage. This template generates ~450 files. With this fix, these 450 files will start having optimized import statements, resulting in lesser memory footprint.