Delete Strings::format and no longer used unlocalized infrastructure.#909
Merged
BillyONeal merged 7 commits intomicrosoft:mainfrom Mar 4, 2023
Merged
Conversation
6220f6a to
a86608b
Compare
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Feb 27, 2023
e1b97d3 to
7edf251
Compare
Merged
7edf251 to
43e69f7
Compare
ras0219-msft
approved these changes
Mar 3, 2023
| @@ -91,25 +91,26 @@ namespace vcpkg::CMakeVars | |||
| const auto& fs = paths.get_filesystem(); | |||
| std::string extraction_file; | |||
Collaborator
There was a problem hiding this comment.
We could construct extraction_file with the initial prelude.
| { | ||
| const std::string name = package.package; | ||
| nodes.append(Strings::format("<Node Id=\"%s\" />", name)); | ||
| fmt::format_to(std::back_inserter(nodes), "<Node Id=\"{}\" />", name); |
Collaborator
There was a problem hiding this comment.
[no change requested] This should really use XmlSerializer...
Contributor
|
This kind of broke the output format of duration. After: |
Contributor
|
Since this PR |
autoantwort
reviewed
Mar 19, 2023
| .string_arg("Bypass") | ||
| .string_arg("-Command") | ||
| .string_arg(Strings::format("& {& '%s' }", script_path)); | ||
| .string_arg(fmt::format("& {& '{}' }", script_path)); |
Contributor
There was a problem hiding this comment.
Probably the reason for the following crash: microsoft/vcpkg#30283
Contributor
There was a problem hiding this comment.
It can solve the problem of {} in the parsing path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the ultimate result of merging the following localization PRs:
This fixes all known localization problems and makes future ones less likely by mostly removing the infrastructure to print unlocalized messages outright.
Audited:
print2(deleted)vcpkg::printf(deleted)Checks::not-msg(deleted)Strings::format(deleted)ExpectedS(deleted)Strings::append(retained)Strings::concat(retained)add_generic_error(retained)