Localize jsonreader infrastructure.#893
Merged
BillyONeal merged 7 commits intomicrosoft:mainfrom Feb 16, 2023
Merged
Conversation
Member
BillyONeal
commented
Feb 11, 2023
- Change type_name and friends to return LocalizedString instead of StringView as this now requires formatting.
- StringDeserializer and ArrayDeserializer are "nerfed" in that they can't provide type_name; this now requires separate derivation because figuring out what type_name is must be deferred until after the current locale is loaded.
* Change type_name and friends to return LocalizedString instead of StringView as this now requires formatting. * StringDeserializer and ArrayDeserializer are "nerfed" in that they can't provide type_name; this now requires separate derivation because figuring out what type_name is must be deferred until after the current locale is loaded.
soroshsabz
reviewed
Feb 11, 2023
|
|
||
| template<class Underlying> | ||
| struct ArrayDeserializer final : IDeserializer<std::vector<typename Underlying::type>> | ||
| struct ArrayDeserializer : IDeserializer<std::vector<typename Underlying::type>> |
Contributor
There was a problem hiding this comment.
Why remove final from this struct?
# Conflicts: # include/vcpkg/paragraphparser.h
# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/base/messages.cpp
JavierMatosD
approved these changes
Feb 16, 2023
Member
Author
|
@JavierMatosD Thanks! |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Feb 16, 2023
* microsoft#893 * [...] Audited: * `print2` (deleted) * `vcpkg::printf` (deleted) * `Checks::not-msg` (deleted) * `Strings::format` (deleted) * `ExpectedS` (deleted) * `Strings::append` (retained) * `Strings::concat` (retained) * `add_generic_error` (retained)
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Feb 16, 2023
* microsoft#893 * [...] Audited: * `print2` (deleted) * `vcpkg::printf` (deleted) * `Checks::not-msg` (deleted) * `Strings::format` (deleted) * `ExpectedS` (deleted) * `Strings::append` (retained) * `Strings::concat` (retained) * `add_generic_error` (retained)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.