Merged
Conversation
BillyONeal
commented
Feb 20, 2023
BillyONeal
commented
Feb 20, 2023
vicroms
approved these changes
Feb 21, 2023
ras0219-msft
approved these changes
Feb 22, 2023
src/vcpkg/binarycaching.cpp
Outdated
| if (auto err = parser.get_error()) | ||
| { | ||
| return Strings::concat(err->to_string(), "\nFor more information, see ", docs::assetcaching_url, "\n"); | ||
| return msg::format(msg::msgErrorMessage) |
Collaborator
There was a problem hiding this comment.
I believe the parser errors are a preformatted "document" including newlines, source information, etc.
If we want to include an additional "Error:", I think it should be on its own line (possibly with more explanation).
Member
Author
There was a problem hiding this comment.
Unfortunately parser errors don't obey the convention IDEs and such respect, because they don't start with the word error. This makes output now like:
PS C:\Dev\vcpkg-tool\out\build\x64-Debug-NoArtifacts> .\vcpkg.exe install zlib
error: $X_VCPKG_ASSET_SOURCES:1:13: error: unexpected arguments: 'clear' does not accept arguments
on expression: clear;clear,bad,bad,bad
^
note: See https://github.com/Microsoft/vcpkg/tree/master/docs/users/assetcaching.md for more information.
so this error prefix is correct but some of the other ones I put "inside" need to be removed.
Member
Author
There was a problem hiding this comment.
Sorry wait I think I have that backwards. Will remove the one here...
# Conflicts: # include/vcpkg/base/messages.h # locales/messages.json # src/vcpkg/base/messages.cpp # src/vcpkg/binarycaching.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.