Localize version resolution algorithms.#936
Merged
BillyONeal merged 4 commits intomicrosoft:mainfrom Feb 27, 2023
Merged
Conversation
JavierMatosD
approved these changes
Feb 27, 2023
vicroms
approved these changes
Feb 27, 2023
…lution # Conflicts: # include/vcpkg/base/messages.h # locales/messages.json
autoantwort
reviewed
Mar 20, 2023
| else | ||
| { | ||
| return format_missing_baseline_message(dep.name, spec); | ||
| msg::format_error(msgVersionConstraintUnresolvable, |
Contributor
There was a problem hiding this comment.
A return is missing here
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 21, 2023
In microsoft#936 , I accidentially forgot the return. Additional related fixes: * add [[nodiscard]] to the formatters; note that nodiscard was already in use in strings.h: https://github.com/microsoft/vcpkg-tool/blob/65fcbac58785083569ce63ad4a9255044bf6c35b/include/vcpkg/base/strings.h#L66 * fix a couple of places that were printing a debug message just before "Checks::unreachable" to include that in the Checks::unreachable output instead of a separate debug statement.
BillyONeal
added a commit
that referenced
this pull request
Mar 21, 2023
* Fix VersionConstraintUnresolvable message being dropped. In #936 , I accidentially forgot the return. Additional related fixes: * add [[nodiscard]] to the formatters; note that nodiscard was already in use in strings.h: https://github.com/microsoft/vcpkg-tool/blob/65fcbac58785083569ce63ad4a9255044bf6c35b/include/vcpkg/base/strings.h#L66 * fix a couple of places that were printing a debug message just before "Checks::unreachable" to include that in the Checks::unreachable output instead of a separate debug statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.