Skip to content

Fix VersionConstraintUnresolvable message being dropped.#970

Merged
BillyONeal merged 3 commits intomicrosoft:mainfrom
BillyONeal:bad-dependency-diagnostic
Mar 21, 2023
Merged

Fix VersionConstraintUnresolvable message being dropped.#970
BillyONeal merged 3 commits intomicrosoft:mainfrom
BillyONeal:bad-dependency-diagnostic

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal commented Mar 21, 2023

In #936 , I accidentially forgot the return.

Additional related fixes:

  • add [[nodiscard]] to the formatters; note that nodiscard was already in use in strings.h:

    vcpkg-tool/include/vcpkg/base/strings.h

    Line 66 in 65fcbac

    [[nodiscard]] std::string concat(const Args&... args)
  • fix a couple of places that were printing a debug message just before "Checks::unreachable" to include that in the Checks::unreachable output instead of a separate debug statement.

Thanks to @Neumann-A for pointing out this bug over Discord and @autoantwort for pointing out which line was messed up after I localized it to #936 .

@BillyONeal
Fix VersionConstraintUnresolvable message being dropped.
7fbf5f7 
In microsoft#936 , I accidentially forgot the return.

Additional related fixes:

* add [[nodiscard]] to the formatters; note that nodiscard was already in use in strings.h: https://github.com/microsoft/vcpkg-tool/blob/65fcbac58785083569ce63ad4a9255044bf6c35b/include/vcpkg/base/strings.h#L66
* fix a couple of places that were printing a debug message just before "Checks::unreachable" to include that in the Checks::unreachable output instead of a separate debug statement.
@autoantwort
Copy link
Copy Markdown
Contributor

autoantwort commented Mar 21, 2023

Btw fixes microsoft/vcpkg#30298

@BillyONeal
Copy link
Copy Markdown
Member Author

BillyONeal commented Mar 21, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 21, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Copy Markdown
Member Author

BillyONeal commented Mar 21, 2023

I'm about this close to just removing the gcov run because failing legitimate builds on Ubuntu randomly is getting old

@BillyONeal BillyONeal merged commit b798a7c into microsoft:main Mar 21, 2023
@BillyONeal BillyONeal deleted the bad-dependency-diagnostic branch March 21, 2023 01:58
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Mar 21, 2023

just removing the gcov run because failing legitimate builds on Ubuntu randomly is getting old

If you think that the gcov step needs some care, you might open an issue and/or ping the contributor.

@BillyONeal
Copy link
Copy Markdown
Member Author

BillyONeal commented Mar 21, 2023

If you think that the gcov step needs some care, you might open an issue and/or ping the contributor.

It just randomly sometimes crashes. There doesn't seem to be a point in trying to follow up with the folks that own it because we're stuck on an old copy (Ubuntu 20.04) until microsoft/azure-pipelines-agent#3834 gets fixed.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Mar 21, 2023

The failing step was "Analyse test coverage". We could

  • make the error non-fatal
  • pin a particular version of gcovr

Or find some expert to get coverage from the MSVC builds instead ;-)

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Mar 21, 2023

or use clang-cl ? It also has a coverage flag.

@BillyONeal
Copy link
Copy Markdown
Member Author

BillyONeal commented Mar 21, 2023 •
edited
Loading

The failing step was "Analyse test coverage". We could

  • make the error non-fatal
  • pin a particular version of gcovr

Or find some expert to get coverage from the MSVC builds instead ;-)

The thing is that nobody here cares about coverage data to invest effort to try to fix this. If it's "someone showed up and turned this on that might be useful someday and doesn't cause any problems", then sure. But not at a significant reliability cost.

or use clang-cl ? It also has a coverage flag.

We have very little control over the environment in which these builds run. (And care about mimicking what users are most likely to have, which is not clang-cl)

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Mar 21, 2023 •
edited
Loading

We have very little control over the environment in which these builds run.

You dont need control if clang-cl is already installed.... (from #972)

Starting: Build vcpkg with CMake
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.212.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\d589167d-2641-4129-b67c-8dfe8838309e.cmd""
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.5.1
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
-- The CXX compiler identification is Clang 15.0.7 with MSVC-like command-line
-- The C compiler identification is Clang 15.0.7 with MSVC-like command-line

Also:

FAILED: CMakeFiles/locale-resources.dir/__cmrc_locale-resources/lib.cpp.obj 
C:\PROGRA~1\LLVM\bin\clang-cl.exe  /nologo -TP  -ID:\a\1\s\build.x64.debug\_cmrc\include /DWIN32 /D_WINDOWS /GR /EHsc /EHsc -FC -permissive- -utf-8 /guard:cf /W4 /sdl -Wmissing-prototypes -Wno-missing-field-initializers /WX /Zi /Ob0 /Od /RTC1 -MTd -std:c++17 /showIncludes /FoCMakeFiles\locale-resources.dir\__cmrc_locale-resources\lib.cpp.obj /FdCMakeFiles\locale-resources.dir\locale-resources.pdb -c -- D:\a\1\s\build.x64.debug\__cmrc_locale-resources\lib.cpp
D:\a\1\s\build.x64.debug\__cmrc_locale-resources\lib.cpp(186,27): error: no previous prototype for function 'get_filesystem' [-Werror,-Wmissing-prototypes]
cmrc::embedded_filesystem get_filesystem() {
                          ^
D:\a\1\s\build.x64.debug\__cmrc_locale-resources\lib.cpp(186,1): note: declare 'static' if the function is not intended to be used outside of this translation unit
cmrc::embedded_filesystem get_filesystem() {
^
static 
1 error generated.
[18/205] Building C object CMakeFiles\tls12-download.dir\src\tls12-download.c.obj
FAILED: CMakeFiles/tls12-download.dir/src/tls12-download.c.obj 
C:\PROGRA~1\LLVM\bin\clang-cl.exe  /nologo   /DWIN32 /D_WINDOWS -FC -permissive- -utf-8 /guard:cf /W4 /sdl -Wmissing-prototypes -Wno-missing-field-initializers /WX /Zi /Ob0 /Od /RTC1 -MT /showIncludes /FoCMakeFiles\tls12-download.dir\src\tls12-download.c.obj /FdCMakeFiles\tls12-download.dir\ -c -- D:\a\1\s\src\tls12-download.c
D:\a\1\s\src\tls12-download.c(30,1): error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn]
}

@autoantwort
Copy link
Copy Markdown
Contributor

autoantwort commented Mar 22, 2023

It also causes my PRs to fail https://github.com/microsoft/vcpkg-tool/pull/908/checks?check_run_id=12190378060 -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

+1 more reviewer

@autoantwort autoantwort autoantwort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BillyONeal @autoantwort @dg0yt @Neumann-A @ras0219-msft