Merged
Conversation
BillyONeal
commented
Feb 23, 2023
JavierMatosD
approved these changes
Feb 27, 2023
| DECLARE_MESSAGE(SearchHelp, | ||
| (), | ||
| "", | ||
| "The argument should be a substring to search for, or no argument to display all libraries."); |
Contributor
There was a problem hiding this comment.
Suggested change
| "The argument should be a substring to search for, or no argument to display all libraries."); | |
| "The argument should be a substring to search for or no argument to display all libraries."); |
include/vcpkg/base/messages.h
Outdated
| DECLARE_MESSAGE(AddVersionOldShaIs, (msg::commit_sha), "", "old SHA: {commit_sha}"); | ||
| DECLARE_MESSAGE(AddVersionOverwriteOptionSuggestion, | ||
| (msg::option), | ||
| "The -- before {option} must be preserved as they're part of the help message for the user.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "The -- before {option} must be preserved as they're part of the help message for the user.", | |
| "The -- before {option} must be preserved as their part of the help message for the user.", |
I know it's not your edit, but I think this should be a possessive pronoun instead. Please ignore if I am wrong :)
Member
Author
There was a problem hiding this comment.
The contraction form is intended here. The --s don't own the help message, they are a part of the help message. I'll add the missing 'a'
include/vcpkg/base/messages.h
Outdated
| @@ -1295,6 +1304,7 @@ namespace vcpkg | |||
| "while fetching baseline `\"{value}\"` from repo {package_name}:"); | |||
| DECLARE_MESSAGE(ErrorWhileParsing, (msg::path), "", "Errors occurred while parsing {path}."); | |||
| DECLARE_MESSAGE(ErrorWhileWriting, (msg::path), "", "Error occured while writing {path}"); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| DECLARE_MESSAGE(ErrorWhileWriting, (msg::path), "", "Error occured while writing {path}"); | |
| DECLARE_MESSAGE(ErrorWhileWriting, (msg::path), "", "Error occurred while writing {path}"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.