P1614R2 Adding Spaceship <=> To The Library#1678
Merged
StephanTLavavej merged 43 commits intomicrosoft:mainfrom Feb 25, 2021
Merged
P1614R2 Adding Spaceship <=> To The Library#1678StephanTLavavej merged 43 commits intomicrosoft:mainfrom
StephanTLavavej merged 43 commits intomicrosoft:mainfrom
Conversation
feature/spaceship: Merge microsoft#1049 (fix <compare> and simplify guards)
Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
feature/spaceship: Merge VS 2019 16.8 Preview 1 toolset update
feature/spaceship: Merge Standard_D16as_v4 VM update
Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Curtis Bezault <cubezaul@microsoft.com>
feature/spaceship: Merge fix for test timing assumption
feature/spaceship: Merge VS 2019 16.8 Preview 2 toolset update
Co-authored-by: Ahana Mukhopadhyay <t-ahmukh@microsoft.com> Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
feature/spaceship: Merge toolset update
feature/spaceship: Merge CI changes to pick up microsoft#1337. This is a clean merge with no additional edits.
feature/spaceship: Merge toolset update
feature/spaceship: Merge toolset update
feature/spaceship: Merge toolset update
feature/spaceship: Merge toolset update
feature/spaceship: Merge CI update
feature/spaceship: Merge toolset update
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
feature/spaceship: Merge LLVM update
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
feature/spaceship: Merge toolset update
NOTE: there was much complicated conflict resolution in `<vector>` to reconcile the work on this branch with the `constexpr vector` work from main.
Feature/spaceship: Merge VMSS update
Co-authored-by: Anju Del Moral Gonzalez <judelmor@microsoft.com> Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
…icrosoft#1665) Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
…oft#1660) Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
feature/spaceship: Merge duration/time_point tests from main
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Ahana Mukhopadhyay <t-ahmukh@microsoft.com> Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Curtis Bezault <cubezaul@microsoft.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Closed
Member
Author
|
Mirrored to internal MSVC-PR-306138 after I had a successful x86chk build and |
AnjuDel
suggested changes
Feb 23, 2021
Member
|
I checked that all my work was correctly merged and it looks it is, with a small minor exception. |
AnjuDel
suggested changes
Feb 24, 2021
AnjuDel
approved these changes
Feb 24, 2021
mnatsuhara
approved these changes
Feb 24, 2021
Contributor
mnatsuhara
left a comment
There was a problem hiding this comment.
The only comments I could find were pathetic whitespace issues - feel free to ignore to avoid rerunning the tests! A monumental amount of work - looks good to me!
| _NODISCARD strong_ordering operator<=>(const shared_ptr<_Ty1>& _Left, const shared_ptr<_Ty2>& _Right) noexcept { | ||
| return _Left.get() <=> _Right.get(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Just so I can comment on something, do we need this blank line here? :)
Member
Author
There was a problem hiding this comment.
I'll remove these lines in a followup PR 😺
| _NODISCARD strong_ordering operator<=>(const shared_ptr<_Ty>& _Left, nullptr_t) noexcept { | ||
| return _Left.get() <=> static_cast<typename shared_ptr<_Ty>::element_type*>(nullptr); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Ditto!
Suggested change
Member
Author
|
Thanks everyone - we're now a warp-capable civilization! 🚀 🛸 ☄️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62.
This merges
feature/spaceshipintomainwith one additional commit. That commit fixes the default template argument oftake_view::sentinelto follow WG21-N4878 [range.take.sentinel], which was the only remaining work for Clause 24 Ranges. (Note thattake_while_view::sentinelwas already doing the right thing.)I plan to mark this feature as complete after merging this PR, with a small amount of remaining work tracked by various issues:
constexpr std::string; it will need to be extended to applyconstexprtostd::stringandstd::string::iterator's spaceships, or we'll need to file a tracking issue.<chrono>spaceships.constexpr std::vectorspaceships (when compiler fixes are available)This feature sets a record for the largest number of contributors in the STL's history! (The previous record-holder was C++17
<filesystem>.) Thanks to everyone who implemented spaceship machinery:🚀 🛸 🪐