feature/spaceship: Clause 30: Regex#1145
Merged
StephanTLavavej merged 15 commits intomicrosoft:feature/spaceshipfrom Aug 20, 2020
Merged
feature/spaceship: Clause 30: Regex#1145StephanTLavavej merged 15 commits intomicrosoft:feature/spaceshipfrom
StephanTLavavej merged 15 commits intomicrosoft:feature/spaceshipfrom
Conversation
Fix bug uncovered by fixed tests.
CaseyCarter
suggested changes
Aug 4, 2020
Contributor
Author
|
It's going to feel so good once that compiler bug is resolved. |
CaseyCarter
approved these changes
Aug 7, 2020
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Only one "real" comment for the extraneous ; - I think the rest of these are style comments and me asking if anyone has filed an LWG issue that I will probably be the one to file.
| inline constexpr bool is_pair<std::pair<A, B>> = true; // TRANSITION, std::pair spaceship not yet implemented | ||
| struct OrderedChar { | ||
| OrderedChar() = default; | ||
| OrderedChar(const char c) : c(c){}; |
Contributor
There was a problem hiding this comment.
Suggested change
| OrderedChar(const char c) : c(c){}; | |
| OrderedChar(const char c) : c(c){} |
Co-authored-by: Casey Carter <Casey@Carter.net>
CaseyCarter
approved these changes
Aug 10, 2020
StephanTLavavej
requested changes
Aug 15, 2020
de36ed3 to
8033dc1
Compare
CaseyCarter
approved these changes
Aug 18, 2020
CaseyCarter
suggested changes
Aug 18, 2020
CaseyCarter
approved these changes
Aug 19, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
approved these changes
Aug 20, 2020
Member
|
Thanks for implementing this fleet of spaceship operators! 🛸 🛸 🛸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement changes required for regex in p1614r2.
Currently I don't rely on comparison operator rewrites because of VSO-900973.