Remove obsolete conditional compilation from <compare>#1049
Merged
StephanTLavavej merged 12 commits intomicrosoft:masterfrom Jul 20, 2020
Merged
Remove obsolete conditional compilation from <compare>#1049StephanTLavavej merged 12 commits intomicrosoft:masterfrom
StephanTLavavej merged 12 commits intomicrosoft:masterfrom
Conversation
Now that EDG has caught up to `__cpp_impl_three_way_comparison == 201907`, we no longer need "downlevel" compatibility for C++20 compilers that either don't define the feature-test macro or define it to a lesser value.
CaseyCarter
commented
Jul 16, 2020
CaseyCarter
commented
Jul 16, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
requested changes
Jul 16, 2020
Member
|
(Re-adding the Spaceship project as this is relevant, although it's targeted at |
StephanTLavavej
requested changes
Jul 17, 2020
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Incrementally approving - only test changes needed now. Really like this improvement!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 17, 2020
... for enregistration, to improve performance. Per a suggestion from Statementreply in the discussion at microsoft#1049 (comment).
StephanTLavavej
approved these changes
Jul 17, 2020
StephanTLavavej
approved these changes
Jul 17, 2020
StephanTLavavej
approved these changes
Jul 18, 2020
Co-authored-by: statementreply <statementreply@gmail.com>
StephanTLavavej
approved these changes
Jul 18, 2020
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 18, 2020
... for enregistration, to improve performance. Per a suggestion from Statementreply in the discussion at microsoft#1049 (comment).
cbezault
approved these changes
Jul 20, 2020
Member
|
Thanks @statementreply for finding this correctness issue before the C++20 ABI locked down, and for improving the fix. Thanks @CaseyCarter for the fix and cleanup, and for helping with the compiler bug investigation. 😸 |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 21, 2020
... for enregistration, to improve performance. Per a suggestion from Statementreply in the discussion at microsoft#1049 (comment).
StephanTLavavej
added a commit
that referenced
this pull request
Jul 21, 2020
feature/spaceship: Merge #1049 (fix <compare> and simplify guards)
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 28, 2020
* Break <compare> ABI again, and fix microsoft#1050. * Remove obsolete conditional compilation from <compare>. Co-authored-by: statementreply <statementreply@gmail.com> Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
CaseyCarter
added a commit
that referenced
this pull request
Jul 30, 2020
... for enregistration, to improve performance. Per a suggestion from Statementreply in the discussion at #1049 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that EDG has caught up to
__cpp_impl_three_way_comparison == 201907, we no longer need "downlevel" compatibility for C++20 compilers that either don't define the feature-test macro or define it to a lesser value. We can now assume that_HAS_CXX20implies__cpp_impl_three_way_comparison >= 201907.Also fixes #1050.