feature/spaceship: Clause 17: Feature-test macro, yvals_core.h comment#1672
Merged
StephanTLavavej merged 2 commits intomicrosoft:feature/spaceshipfrom Feb 22, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
CaseyCarter
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works towards #62.
This adds P1614R2 Adding Spaceship
<=>To The Library toyvals_core.h's list of_HAS_CXX20features, and increases the value of the feature-test macro as specified in WG21-N4878 (see SD-FeatureTest to double-check). The feature-test macro remains additionally guarded by__cpp_lib_concepts. Finally, this updates the test accordingly, and unskips libcxx's test.After this PR, the only remaining work for Clause 17 Language Support is #489 (where we need compiler support).