feature/spaceship: Clause 20: variant, monostate#1657
Merged
StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom Feb 19, 2021
Merged
feature/spaceship: Clause 20: variant, monostate#1657StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom
StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom
Conversation
CaseyCarter
suggested changes
Feb 17, 2021
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Nitpicky things. High-level approach is great.
CaseyCarter
suggested changes
Feb 18, 2021
CaseyCarter
approved these changes
Feb 18, 2021
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - I'll add a commit to enhance the test coverage.
StephanTLavavej
approved these changes
Feb 18, 2021
CaseyCarter
approved these changes
Feb 19, 2021
Member
|
Thanks for implementing one of C++20's most complicated spaceships (and its least complicated! 😹) and congratulations on your first microsoft/STL commit! 🎉 🚀 🛸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.