feature/spaceship: Merge toolset update#1404
Merged
StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom Oct 27, 2020
Merged
feature/spaceship: Merge toolset update#1404StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom
StephanTLavavej merged 6 commits intomicrosoft:feature/spaceshipfrom
Conversation
MSVC is finally getting around to implementing `[[no_unique_address]]`, which will result in class layout differing with Clang. Let's comment out the uses that are not yet so commented until we reach compiler parity.
CaseyCarter
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up #1399.
Merge conflict in
tests/std/test.lstbecausetests\P1502R1_standard_library_header_unitswas added next totests\P1614R2_spaceship. Took both changes and sorted them.