Merged
Conversation
MSVC is finally getting around to implementing `[[no_unique_address]]`, which will result in class layout differing with Clang. Let's comment out the uses that are not yet so commented until we reach compiler parity.
StephanTLavavej
approved these changes
Oct 10, 2020
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good to me. I checked out the branch and searched to verify that all occurrences of no_unique_address are commented out.
miscco
approved these changes
Oct 10, 2020
Contributor
miscco
left a comment
There was a problem hiding this comment.
Looks good, am I understanding it correctly that the feature is WIP in the MSVC side and we do not want to interfere with their work?!
Contributor
|
My understanding is to avoid ABI/ODR issues between TUs compiled with Clang and TUs compiled with MSVC, until both reach parity. |
3 tasks
Member
mnatsuhara
approved these changes
Oct 22, 2020
Contributor
Author
|
Thanks for addressing this unique problem no-more. (There's no functional change here, so not Changelogging.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC is finally getting around to implementing
[[no_unique_address]], which will result in class layout differing with Clang. Let's comment out the uses that are not yet so commented until we reach compiler parity.Related to MSVC-PR-280491, which implements
[[no_unique_address]]"for real" in MSVC.