feat: gracefully handle when a merge conflict happens with a simulated merge#154
feat: gracefully handle when a merge conflict happens with a simulated merge#154levibostian merged 3 commits intomainfrom
Conversation
…d merge When we perform a simulated merge, we use many different merge types, and it can be common for there to be a merge conflict when trying to rebase, for example. Now, in the GitHub UI, you will also see that merge conflict, and they won't even allow you to click the merge button because of the merge conflict. We should gracefully handle it just the same, knowing the user can't actually merge the pull request anyway. So, instead of crashing the app, we should gracefully handle it and exit with a zero code, knowing the user can't merge anyway using rebase. They could use a different method instead. For this reason, we shouldn't fail or anything.
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 0.12.0 Learn moreLatest release: 0.11.1 Commit of latest release: 74aa739 Commits since last release: - feat: gracefully handle when a merge conflict happens with a simulated merge Related GitHub Issues<!-- Link to any related GitHub issues that this pull request addresses or closes. --> Problem<!-- A clear description of the problem that this pull request is solving. --> When we perform a simulated merge, we use many different merge types, and it can be common for there to be a merge conflict when trying to rebase, for example. This causes decaf to crash on the CI, which feels not right. A crash shouldn't occur for something that is possible to occur. Solution<!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> In the GitHub UI, you will also see that merge conflict, and they won't even allow you to click the merge button because of the merge conflict. We should gracefully handle it just the same, knowing the user can't actually merge the pull request anyway. So, instead of crashing the app, we should gracefully handle it and exit with a zero code, knowing the user can't merge anyway using rebase. They could use a different method instead. Testing<!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. -->
Notes for reviewers<!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. --> This PR contains the following updates:
Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#32615)
(#32521)
(#32430)
(#32594)
(#32609)
(#32581)
(#32495)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#32467)
(#32329)
(#32410)
(#32403)
(#32421)
(#32378)
(#32300)
(#32291)
(#32401)
(#32345)
(#32389)
(#31958)
(#32407)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)Read more: http://deno.com/blog/v2.7
(#31977)
(#31848)
(#32183)
(#32284)
(#32249)
(#32264)
(#32277)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ...🟩 rebase 🟩 merge method... 🚢 The next version of the project will be: 0.12.0 Learn moreLatest release: 0.11.1 Commit of latest release: 74aa739 Commits since last release: - refactor: move from describe/it to Deno.test syntax for test functions - feat: gracefully handle when a merge conflict happens with a simulated merge When we perform a simulated merge, we use many different merge types, and it can be common for there to be a merge conflict when trying to rebase, for example. Now, in the GitHub UI, you will also see that merge conflict, and they won't even allow you to click the merge button because of the merge conflict. We should gracefully handle it just the same, knowing the user can't actually merge the pull request anyway. So, instead of crashing the app, we should gracefully handle it and exit with a zero code, knowing the user can't merge anyway using rebase. They could use a different method instead. For this reason, we shouldn't fail or anything. This PR contains the following updates:
Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#32615)
(#32521)
(#32430)
(#32594)
(#32609)
(#32581)
(#32495)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#32467)
(#32329)
(#32410)
(#32403)
(#32421)
(#32378)
(#32300)
(#32291)
(#32401)
(#32345)
(#32389)
(#31958)
(#32407)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
| Release NotesConfiguration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)Read more: http://deno.com/blog/v2.7
(#31977)
(#31848)
(#32183)
(#32284)
(#32249)
(#32264)
(#32277)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Disabled by config. Please merge this manually once you ♻ Rebasing: Whenever PR becomes conflicted, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> |
Related GitHub Issues
Problem
When we perform a simulated merge, we use many different merge types, and it can be common for there to be a merge conflict when trying to rebase, for example. This causes decaf to crash on the CI, which feels not right. A crash shouldn't occur for something that is possible to occur.
Solution
In the GitHub UI, you will also see that merge conflict, and they won't even allow you to click the merge button because of the merge conflict.
We should gracefully handle it just the same, knowing the user can't actually merge the pull request anyway. So, instead of crashing the app, we should gracefully handle it and exit with a zero code, knowing the user can't merge anyway using rebase. They could use a different method instead.
Testing
Notes for reviewers