fix(ext/node): add missing http2 header constants#32611
Merged
littledivy merged 1 commit intodenoland:mainfrom Mar 10, 2026
Merged
fix(ext/node): add missing http2 header constants#32611littledivy merged 1 commit intodenoland:mainfrom
littledivy merged 1 commit intodenoland:mainfrom
Conversation
Adds missing HTTP2_HEADER_ACCEPT_ENCODING and related constants that grpc-js depends on. Without these, grpc-js crashes with: TypeError: Cannot read properties of undefined (reading 'toLowerCase') when trying to normalize header keys in Metadata.remove(). Added constants: - HTTP2_HEADER_ACCEPT - HTTP2_HEADER_ACCEPT_ENCODING - HTTP2_HEADER_ACCEPT_LANGUAGE - HTTP2_HEADER_ACCEPT_RANGES Fixes part of denoland#26436
littledivy
approved these changes
Mar 10, 2026
bartlomieju
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing HTTP2_HEADER_ACCEPT_ENCODING and related constants that grpc-js depends on. Without these, grpc-js server crashes with:
when trying to normalize header keys in
BaseServerInterceptingCall.Added constants:
HTTP2_HEADER_ACCEPTHTTP2_HEADER_ACCEPT_ENCODINGHTTP2_HEADER_ACCEPT_LANGUAGEHTTP2_HEADER_ACCEPT_RANGESTesting
With this fix, grpc-js server can handle requests:
Found while testing #26436 (which is fixed by the http2 rewrite).