Skip to content

perf(npm): remove folder canonicalization in tarball extract#32540

Merged
dsherret merged 1 commit intodenoland:mainfrom
dsherret:perf_disable_canonicalization_tarball_extract
Mar 6, 2026
Merged

perf(npm): remove folder canonicalization in tarball extract#32540
dsherret merged 1 commit intodenoland:mainfrom
dsherret:perf_disable_canonicalization_tarball_extract

Conversation

@dsherret
Copy link
Copy Markdown
Contributor

@dsherret dsherret commented Mar 6, 2026

We can do this security check all in memory.

Pretty similar, but slightly faster:

% ./bench.sh                                         
Benchmark 1: ../deno/target/release/deno_main install --env-file
  Time (mean ± σ):      1.467 s ±  0.031 s    [User: 0.521 s, System: 2.159 s]
  Range (min … max):    1.445 s …  1.503 s    3 runs
 
Benchmark 2: ../deno/target/release/deno install --env-file
  Time (mean ± σ):      1.390 s ±  0.057 s    [User: 0.519 s, System: 2.193 s]
  Range (min … max):    1.348 s …  1.454 s    3 runs
 
Summary
  ../deno/target/release/deno install --env-file ran
    1.06 ± 0.05 times faster than ../deno/target/release/deno_main install --env-file

@dsherret dsherret merged commit 6b73c27 into denoland:main Mar 6, 2026
113 checks passed
@dsherret dsherret deleted the perf_disable_canonicalization_tarball_extract branch March 6, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants