fix(node): preserve AsyncLocalStorage context in stream.finished callback#32389
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Mar 2, 2026
Merged
Conversation
…callback Snapshot the async context when `eos()` is called and restore it around the callback invocation so that `AsyncLocalStorage.getStore()` returns the expected value inside `stream.finished` callbacks. Node.js propagates async context automatically through its native `AsyncWrap`/`InternalCallbackScope` C++ layer, but Deno's ops don't flow through that path, so the context was lost by the time the stream emitted `close`/`finish`/`end`. Closes denoland#32327 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
littledivy
approved these changes
Mar 2, 2026
| // layer, but Deno's ops don't propagate Node-style async context. | ||
| const snapshot = core.getAsyncContext(); | ||
| const originalCallback = callback; | ||
| callback = function (...args) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eos()(the implementation behindstream.finished) is called and restores it around the callback invocationAsyncWrap/InternalCallbackScopeC++ layer (src/api/callback.cc), but Deno's ops don't flow through that path, soAsyncLocalStorage.getStore()returnedundefinedinsidestream.finishedcallbacksCloses #32327
Test plan
asyncLocalStoragePreservedInStreamFinishedunit test intests/unit_node/async_hooks_test.tsOK: got expected valueunit_node::async_hooks_testsuite passes🤖 Generated with Claude Code