fix(ext/node): emit DEP0198 warning for SHAKE digests without outputLength#32521
Merged
bartlomieju merged 4 commits intodenoland:mainfrom Mar 9, 2026
Merged
Conversation
…ength Emit a DeprecationWarning (DEP0198) when creating SHAKE128/256 digests without an explicit `options.outputLength`, matching Node.js behavior with `--pending-deprecation`. Enables `test-crypto-default-shake-lengths.js` and `test-crypto-default-shake-lengths-oneshot.js` in node_compat. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kajukitli
reviewed
Mar 6, 2026
Contributor
kajukitli
left a comment
There was a problem hiding this comment.
lgtm, straightforward change.
one minor nit: you're calling algorithm.toLowerCase() twice. could do:
const algoLower = algorithm.toLowerCase();
if (!isCopy && xofLen === undefined && (algoLower === "shake128" || algoLower === "shake256")) {not a big deal since this only runs once per Hash construction, but cleaner.
…precation-warning
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeprecationWarning(DEP0198) when creating SHAKE128/256 digests without an explicitoptions.outputLength, matching Node.js behavior with--pending-deprecationtest-crypto-default-shake-lengths.jsandtest-crypto-default-shake-lengths-oneshot.jsin node_compatTest plan
cargo test --test node_compat test-crypto-default-shake-lengths— 2 tests pass🤖 Generated with Claude Code