Reland refactor(core): move nextTick/immediate queues into core, replace ops with shared buffers (#32440)#32465
Merged
bartlomieju merged 4 commits intodenoland:mainfrom Mar 4, 2026
Merged
Conversation
…lace ops with shared buffers (denoland#32440) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The nextTick rewrite moved unhandled rejection processing into processTicksAndRejections (JS-side), but "rejectionhandled" events were still only dispatched from Rust's dispatch_rejections, which runs after tick draining. This caused rejectionhandled to fire after unhandledrejection for later promises, breaking the expected ordering. Fix by extracting dispatch_handled_rejections and calling it before both the tick drain in the event loop and between timer callbacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathanwhit
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processTicksAndRejections(JS-sideprocessPromiseRejections), butrejectionhandledevents were still only dispatched from Rust'sdispatch_rejections, which runs after tick draining. This causedrejectionhandledto fire afterunhandledrejectionfor later promises, breaking expected event ordering.dispatch_handled_rejectionsfromdispatch_rejectionsand call it before both the tick drain in the main event loop and between timer callbacks indispatch_timers.deno_core_testing::integration::error_rejection_catch.Test plan
cargo nextest run -p deno_core— all 354 tests passcargo nextest run -p deno_core_testing— all 54 tests pass (including previously failingerror_rejection_catch)🤖 Generated with Claude Code