[Merged by Bors] - refactor: use IsLeftCancelMul etc#945
Closed
[Merged by Bors] - refactor: use IsLeftCancelMul etc#945
IsLeftCancelMul etc#945Conversation
eric-wieser
approved these changes
Dec 10, 2022
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Looks reasonable, but someone more involved in the port should double-check
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2022
This is the Lean 4 version of leanprover-community/mathlib3#17884.
|
Pull request successfully merged into master. Build succeeded: |
IsLeftCancelMul etcIsLeftCancelMul etc
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Dec 10, 2022
The Lean 4 version is here: leanprover-community/mathlib4#945.
bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2023
All these changes in Mathlib 3 were backported from this repository or were forward-ported earler. ## Port status pages * [`topology.basic`@`8631e2d5ea77f6c13054d9151d82b83069680cb1`..`bcfa726826abd57587355b4b5b7e78ad6527b7e4`](https://leanprover-community.github.io/mathlib-port-status/file/topology/basic?range=8631e2d5ea77f6c13054d9151d82b83069680cb1..bcfa726826abd57587355b4b5b7e78ad6527b7e4) * [`topology.separation`@`59694bd07f0a39c5beccba34bd9f413a160782bf`..`92ca63f0fb391a9ca5f22d2409a6080e786d99f7`](https://leanprover-community.github.io/mathlib-port-status/file/topology/separation?range=59694bd07f0a39c5beccba34bd9f413a160782bf..92ca63f0fb391a9ca5f22d2409a6080e786d99f7) * [`order.filter.basic`@`996b0ff959da753a555053a480f36e5f264d4207`..`24e75f1ee89ff37e99581084704f3f6a950db2ea`](https://leanprover-community.github.io/mathlib-port-status/file/order/filter/basic?range=996b0ff959da753a555053a480f36e5f264d4207..24e75f1ee89ff37e99581084704f3f6a950db2ea) * [`order.basic`@`d4f69d96f3532729da8ebb763f4bc26fcf640f06`..`1f0096e6caa61e9c849ec2adbd227e960e9dff58`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=d4f69d96f3532729da8ebb763f4bc26fcf640f06..1f0096e6caa61e9c849ec2adbd227e960e9dff58) * [`algebra.group.type_tags`@`6eb334bd8f3433d5b08ba156b8ec3e6af47e1904`..`2e0975f6a25dd3fbfb9e41556a77f075f6269748`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/type_tags?range=6eb334bd8f3433d5b08ba156b8ec3e6af47e1904..2e0975f6a25dd3fbfb9e41556a77f075f6269748) ## Relevant PRs * `Topology.Basic`: #1957 * `Order.Filter.Basic`: #1953 * `Order.Basic`: #1738 * `Algebra.Group.TypeTags`: #945
mo271
pushed a commit
that referenced
this pull request
Feb 18, 2023
All these changes in Mathlib 3 were backported from this repository or were forward-ported earler. ## Port status pages * [`topology.basic`@`8631e2d5ea77f6c13054d9151d82b83069680cb1`..`bcfa726826abd57587355b4b5b7e78ad6527b7e4`](https://leanprover-community.github.io/mathlib-port-status/file/topology/basic?range=8631e2d5ea77f6c13054d9151d82b83069680cb1..bcfa726826abd57587355b4b5b7e78ad6527b7e4) * [`topology.separation`@`59694bd07f0a39c5beccba34bd9f413a160782bf`..`92ca63f0fb391a9ca5f22d2409a6080e786d99f7`](https://leanprover-community.github.io/mathlib-port-status/file/topology/separation?range=59694bd07f0a39c5beccba34bd9f413a160782bf..92ca63f0fb391a9ca5f22d2409a6080e786d99f7) * [`order.filter.basic`@`996b0ff959da753a555053a480f36e5f264d4207`..`24e75f1ee89ff37e99581084704f3f6a950db2ea`](https://leanprover-community.github.io/mathlib-port-status/file/order/filter/basic?range=996b0ff959da753a555053a480f36e5f264d4207..24e75f1ee89ff37e99581084704f3f6a950db2ea) * [`order.basic`@`d4f69d96f3532729da8ebb763f4bc26fcf640f06`..`1f0096e6caa61e9c849ec2adbd227e960e9dff58`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=d4f69d96f3532729da8ebb763f4bc26fcf640f06..1f0096e6caa61e9c849ec2adbd227e960e9dff58) * [`algebra.group.type_tags`@`6eb334bd8f3433d5b08ba156b8ec3e6af47e1904`..`2e0975f6a25dd3fbfb9e41556a77f075f6269748`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/type_tags?range=6eb334bd8f3433d5b08ba156b8ec3e6af47e1904..2e0975f6a25dd3fbfb9e41556a77f075f6269748) ## Relevant PRs * `Topology.Basic`: #1957 * `Order.Filter.Basic`: #1953 * `Order.Basic`: #1738 * `Algebra.Group.TypeTags`: #945
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Update some SHAs of files that changed in mathlib3. These 17 files need mainly only updated SHA as they've been only touched by backports or already have been forward-ported. The relevant changes are: * [Algebra.Group.Defs (#17884)](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/defs?range=41cf0cc2f528dd40a8f2db167ea4fb37b8fde7f3..2e0975f6a25dd3fbfb9e41556a77f075f6269748) * #945 * [Algebra.Group.WithOne.Defs (#18081)](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/with_one/defs?range=e574b1a4e891376b0ef974b926da39e05da12a06..995b47e555f1b6297c7cf16855f1023e355219fb) * #1439 * [Algebra.Module.Submodule.Basic (#18291) : backport](https://leanprover-community.github.io/mathlib-port-status/file/algebra/module/submodule/basic?range=f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c..feb99064803fd3108e37c18b0f77d0a8344677a3) * [Algebra.Order.Monoid.WithTop (#18149, #18081)](https://leanprover-community.github.io/mathlib-port-status/file/algebra/order/monoid/with_top?range=2258b40dacd2942571c8ce136215350c702dc78f..e7e2ba8aa216a5833b5ed85a93317263711a36b5) * #1508 * #1439 * [Algebra.Order.Ring.WithTop (#18149, #18081)](https://leanprover-community.github.io/mathlib-port-status/file/algebra/order/ring/with_top?range=550b58538991c8977703fdeb7c9d51a5aa27df11..e7e2ba8aa216a5833b5ed85a93317263711a36b5) * #1508 * #1439 * [Data.Finset.NAry (#18081)](https://leanprover-community.github.io/mathlib-port-status/file/data/finset/n_ary?range=9003f28797c0664a49e4179487267c494477d853..995b47e555f1b6297c7cf16855f1023e355219fb) * #1439 * [Data.Option.NAry (#18081)](https://leanprover-community.github.io/mathlib-port-status/file/data/option/n_ary?range=2258b40dacd2942571c8ce136215350c702dc78f..995b47e555f1b6297c7cf16855f1023e355219fb) * #1439 * [Data.Set.NAry (#18081)](https://leanprover-community.github.io/mathlib-port-status/file/data/set/n_ary?range=2ed7e4aec72395b6a7c3ac4ac7873a7a43ead17c..995b47e555f1b6297c7cf16855f1023e355219fb) * #1439 * [Data.SetLike.Basic (#18291) : backport](https://leanprover-community.github.io/mathlib-port-status/file/data/set_like/basic?range=fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e..feb99064803fd3108e37c18b0f77d0a8344677a3) * [Data.Sum.Basic (#18184)](https://leanprover-community.github.io/mathlib-port-status/file/data/sum/basic?range=d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d..f4ecb599422baaf39055d8278c7d9ef3b5b72b88) * #1583 * [GroupTheory.GroupAction.SubMulAction (#18291) : backport](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/group_action/sub_mul_action?range=f93c11933efbc3c2f0299e47b8ff83e9b539cbf6..feb99064803fd3108e37c18b0f77d0a8344677a3) * [GroupTheory.Submonoid.Basic (#18291) : backport](https://leanprover-community.github.io/mathlib-port-status/file/group_theory/submonoid/basic?range=207cfac9fcd06138865b5d04f7091e46d9320432..feb99064803fd3108e37c18b0f77d0a8344677a3) * [ Logic.Basic (#18291): backport](https://leanprover-community.github.io/mathlib-port-status/file/logic/basic?range=1c521b4fb909320eca16b2bb6f8b5b0490b1cb5e..feb99064803fd3108e37c18b0f77d0a8344677a3) * #1509 * [Order.InitialSeg (#18198): backport](https://leanprover-community.github.io/mathlib-port-status/file/order/initial_seg?range=ee0c179cd3c8a45aa5bffbf1b41d8dbede452865..7c3269ca3fa4c0c19e4d127cd7151edbdbf99ed4) * [Order.RelClasses (#17957)](https://leanprover-community.github.io/mathlib-port-status/file/order/rel_classes?range=c4658a649d216f57e99621708b09dcb3dcccbd23..bc7d81beddb3d6c66f71449c5bc76c38cb77cf9e) * #1047 * [Order.WithBot (#18081)](https://leanprover-community.github.io/mathlib-port-status/file/order/with_bot?range=70d50ecfd4900dd6d328da39ab7ebd516abe4025..995b47e555f1b6297c7cf16855f1023e355219fb) * #1439 * [RingTheory.Subsemiring.Basic (#18291) : backport](https://leanprover-community.github.io/mathlib-port-status/file/ring_theory/subsemiring/basic?range=f93c11933efbc3c2f0299e47b8ff83e9b539cbf6..feb99064803fd3108e37c18b0f77d0a8344677a3) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Lean 4 version of leanprover-community/mathlib3#17884.