Skip to content

[Merged by Bors] - feat: inclusion-exclusion principle#17957

Closed
YaelDillies wants to merge 5 commits intomasterfrom
inclusion_exclusion
Closed

[Merged by Bors] - feat: inclusion-exclusion principle#17957
YaelDillies wants to merge 5 commits intomasterfrom
inclusion_exclusion

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Oct 19, 2024 •
edited
Loading

@YaelDillies YaelDillies added WIP Work in progress t-combinatorics Combinatorics labels Oct 19, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 19, 2024 •
edited
Loading

PR summary 2a3cd43d2a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.Enumerative.InclusionExclusion 619

Declarations diff

+ inclusion_exclusion_card_biUnion
+ inclusion_exclusion_card_inf_compl
+ inclusion_exclusion_sum_biUnion
+ inclusion_exclusion_sum_inf_compl
+ prod_filter_not_mul_prod_filter
+ prod_indicator_biUnion_sub_indicator

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 20, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 20, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 21, 2024
@YaelDillies YaelDillies removed the WIP Work in progress label Oct 21, 2024
@YaelDillies YaelDillies mentioned this pull request Oct 27, 2024
Closed
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 27, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Oct 27, 2024

This PR/issue depends on:

@YaelDillies YaelDillies requested a review from b-mehta November 11, 2024 16:34
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 11, 2024
@YaelDillies
feat: inclusion-exclusion principle
4585a9d 
It was a long-standing TODO to have this in mathlib.
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 11, 2024
urkud
urkud reviewed Nov 18, 2024
View reviewed changes
faenuccio
faenuccio reviewed Nov 18, 2024
View reviewed changes
faenuccio
faenuccio reviewed Nov 19, 2024
View reviewed changes
faenuccio
faenuccio reviewed Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@faenuccio faenuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from two very minor suggestions for the doc, this looks good to me. Thanks!

@faenuccio
Copy link
Copy Markdown
Contributor

faenuccio commented Nov 19, 2024

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 19, 2024

🚀 Pull request has been placed on the maintainer queue by faenuccio.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 19, 2024
@urkud
Copy link
Copy Markdown
Member

urkud commented Nov 19, 2024

Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 19, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 19, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor Author

YaelDillies commented Nov 19, 2024

Thank you both for the quick review!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@YaelDillies
feat: inclusion-exclusion principle (#17957)
d6c2c91 
It was a long-standing TODO to have this in mathlib.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: inclusion-exclusion principle [Merged by Bors] - feat: inclusion-exclusion principle Nov 19, 2024
@mathlib-bors mathlib-bors bot closed this Nov 19, 2024
@mathlib-bors mathlib-bors bot deleted the inclusion_exclusion branch November 19, 2024 17:06
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
@YaelDillies @TobiasLeichtfried
feat: inclusion-exclusion principle (#17957)
7dadf39 
It was a long-standing TODO to have this in mathlib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urkud urkud urkud left review comments

@faenuccio faenuccio faenuccio left review comments

@b-mehta b-mehta Awaiting requested review from b-mehta

Assignees

@faenuccio faenuccio

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-combinatorics Combinatorics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YaelDillies @mathlib4-dependent-issues-bot @faenuccio @urkud @leanprover-community-bot-assistant