[Merged by Bors] - fix(Algebra/DirectSum/Internal): delete some instances#18149
Closed
[Merged by Bors] - fix(Algebra/DirectSum/Internal): delete some instances#18149
Conversation
PR summary c1e3767f59Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Contributor
|
!bench |
Member
|
!bench |
Member
Author
|
heh, you both took the words out of my mouth :-) |
Member
|
Ops, I didn't see Matthew also benched it |
Collaborator
|
Here are the benchmark results for commit c1e3767. |
|
Contributor
|
Seems fine to me |
Member
|
I agree |
Member
|
Yes, looks good. bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
See [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/rewrite.20failure.20on.20Subalgebra/near/478555535) discussion. One of these instances was breaking user code.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Zulip discussion. One of these instances was breaking user code.