[Merged by Bors] - feat: indicator of a clopen set as a bounded continuous function#18291
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - feat: indicator of a clopen set as a bounded continuous function#18291YaelDillies wants to merge 2 commits intomasterfrom
YaelDillies wants to merge 2 commits intomasterfrom
Conversation
PR summary 4cd6b85efaImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Ruben-VandeVelde
approved these changes
Oct 28, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Simple enough
maintainer merge
|
|
||
| theorem norm_indicator_le_one (s : Set α) (x : α) : ‖(indicator s (1 : α → ℝ)) x‖ ≤ 1 := by | ||
| simp only [indicator, Pi.one_apply]; split_ifs <;> norm_num | ||
| simp only [Set.indicator, Pi.one_apply]; split_ifs <;> norm_num |
Contributor
There was a problem hiding this comment.
Is this a (weak) indication that the new one should be protected?
Contributor
Author
There was a problem hiding this comment.
Maybe, but in general I think it's fine to have both A.X and B.X unprotected.
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
jcommelin
pushed a commit
that referenced
this pull request
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From PFR