This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(algebra/group/defs): use is_left_cancel_mul etc#17884
Closed
[Merged by Bors] - refactor(algebra/group/defs): use is_left_cancel_mul etc#17884
is_left_cancel_mul etc#17884Conversation
eric-wieser
approved these changes
Dec 10, 2022
Member
eric-wieser
left a comment
There was a problem hiding this comment.
LGTM, as long as you're happy to deal with porting this
bors d+
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
@eric-wieser Should I merge this now, or wait till the Lean 4 version is merged? |
Member
|
I think that's a question for the #mathlib4 stream |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 10, 2022
This is the Lean 4 version of leanprover-community/mathlib3#17884.
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2022
The Lean 4 version is here: leanprover-community/mathlib4#945.
|
Pull request successfully merged into master. Build succeeded: |
is_left_cancel_mul etcis_left_cancel_mul etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lean 4 version is here: leanprover-community/mathlib4#945.
I can port this to
mathlib4over the weekend.