Skip to content

[Merged by Bors] - feat: port Order.Hom.Basic#804

Closed
kim-em wants to merge 35 commits intomasterfrom
order_hom_basic
Closed

[Merged by Bors] - feat: port Order.Hom.Basic#804
kim-em wants to merge 35 commits intomasterfrom
order_hom_basic

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Nov 30, 2022

mathlib3 git sha 62a5626868683c104774de8d85b9855234ac807c

@kim-em kim-em added WIP Work in progress please-adopt Inactive PR (would be valuable to adopt) labels Nov 30, 2022
@kim-em kim-em added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 30, 2022
@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 30, 2022
@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label Nov 30, 2022
@ChrisHughes24
Copy link
Copy Markdown
Member

Some Type Class issues came up trying to port this which I have reported on Zulip

@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 1, 2022
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 2, 2022
@kim-em kim-em added awaiting-review and removed WIP Work in progress please-adopt Inactive PR (would be valuable to adopt) labels Dec 6, 2022
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 6, 2022
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Dec 6, 2022

bors merge

@bors
Copy link
Copy Markdown

bors bot commented Dec 6, 2022

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 6, 2022
@kim-em kim-em added awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Dec 6, 2022
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Dec 6, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 6, 2022
mathlib3 git sha 62a5626868683c104774de8d85b9855234ac807c

- [x] depends on: #772 
- [x] depends on: #838

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@bors
Copy link
Copy Markdown

bors bot commented Dec 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Hom.Basic [Merged by Bors] - feat: port Order.Hom.Basic Dec 6, 2022
@bors bors bot closed this Dec 6, 2022
@bors bors bot deleted the order_hom_basic branch December 6, 2022 04:00
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Dec 7, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.divisibility.units`: leanprover-community/mathlib4#848
* `algebra.group.type_tags`: leanprover-community/mathlib4#832
* `algebra.group_with_zero.divisibility`: leanprover-community/mathlib4#870
* `algebra.hom.equiv.basic`: leanprover-community/mathlib4#835
* `algebra.order.group.defs`: leanprover-community/mathlib4#869
* `algebra.order.monoid.basic`: leanprover-community/mathlib4#872
* `algebra.order.monoid.cancel.basic`: leanprover-community/mathlib4#883
* `algebra.order.monoid.with_zero.defs`: leanprover-community/mathlib4#851
* `algebra.order.monoid.with_zero.basic`: leanprover-community/mathlib4#851
* `algebra.ring.divisibility`: leanprover-community/mathlib4#864
* `data.list.defs`: leanprover-community/mathlib4#803
* `data.sigma.order`: leanprover-community/mathlib4#887
* `group_theory.group_action.defs`: leanprover-community/mathlib4#854
* `order.heyting.boundary`: leanprover-community/mathlib4#844
* `order.hom.basic`: leanprover-community/mathlib4#804
* `order.symm_diff`: leanprover-community/mathlib4#842



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants